Skip to content

fix: do not render images twice on markdown - #1897

Merged
santhoshvai merged 1 commit into
developfrom
santhosh/fix-duplicate-images-on-markdown
Jan 6, 2023
Merged

santhoshvai merged 1 commit into
developfrom
santhosh/fix-duplicate-images-on-markdown

Conversation

@santhoshvai

@santhoshvai santhoshvai commented Jan 6, 2023 •

Copy link
Copy Markdown
Member

🎯 Goal

Fixes #1883

🛠 Implementation details

Disables the markdown parser for images. This is in alignment with iOS SDK and react SDK.

🎨 UI Changes

iOS
Before After
Android
Before After

🧪 Testing

Put this message ![Some GIF](https://media.giphy.com/media/dkGhBWE3SyzXW/giphy.gif). You should see only one gif.

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@santhoshvai santhoshvai self-assigned this Jan 6, 2023
@santhoshvai
santhoshvai requested a review from khushal87 January 6, 2023 10:38
@santhoshvai
santhoshvai merged commit 72c80f6 into develop Jan 6, 2023
@santhoshvai
santhoshvai deleted the santhosh/fix-duplicate-images-on-markdown branch January 6, 2023 10:41
@cengizhanhakan

Copy link
Copy Markdown

Great news, thanks!

@santhoshvai

Copy link
Copy Markdown
Member Author

thanks a lot for filing the issue @cengizhanhakan

@github-actions github-actions Bot mentioned this pull request Jan 12, 2023
@vishalnarkhede

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 5.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 GIFs in one single message

4 participants