Skip to content

fix: crash when editing messages with video attachments #3968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isekovanic merged 1 commit into from
Nov 10, 2026
Merged

fix: crash when editing messages with video attachments #3968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions package/src/components/MessageInput/__tests__/AttachmentUploadPreviewList.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import {
generateImageAttachment as generateImageAttachmentBase,
generateVideoAttachment as generateVideoAttachmentBase,
} from '../../../mock-builders/attachments';
import { generateMessage } from '../../../mock-builders/generator/message';

import { FileState } from '../../../utils/utils';
import { Channel } from '../../Channel/Channel';
Expand Down Expand Up @@ -629,4 +630,27 @@ describe('AttachmentUploadPreviewList', () => {
});
});
});

describe('VideoAttachmentUploadPreview', () => {
it('renders a video restored from a sent message, which has no local file', async () => {
act(() => {
channel.messageComposer.initState({
composition: generateMessage({
attachments: [
generateVideoAttachmentBase({
asset_url: 'https://video-attachment.mp4',
thumb_url: 'https://video-attachment-thumb.png',
}),
],
}),
});
});

renderComponent({ channel, client, props: {} });

await waitFor(() => {
expect(screen.queryAllByTestId('image-attachment-upload-preview')).toHaveLength(1);
});
});
});
});
2 changes: 1 addition & 1 deletion ...src/components/MessageInput/components/AttachmentPreview/VideoAttachmentUploadPreview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export const VideoAttachmentUploadPreview = ({
// `localMetadata.file` is `File | FileReference`; only the RN `FileReference` carries a
// `duration` (and a required `uri` to discriminate on), so read it through a guard.
const localFile = attachment.localMetadata.file;
const duration = 'uri' in localFile ? localFile.duration : undefined;
const duration = localFile && 'uri' in localFile ? localFile.duration : undefined;

return previewUri ? (
<>
Expand Down
Loading