Skip to content

fix(LinkPreviewList): take the preview thumbnail from image_url or thumb_url #3392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinCupela merged 1 commit into from
Nov 5, 2026
Merged

fix(LinkPreviewList): take the preview thumbnail from image_url or thumb_url #3392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/MessageComposer/LinkPreviewList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,15 +51,15 @@ export const LinkPreviewCard = ({ linkPreview }: LinkPreviewProps) => {
const { handleEnter, handleLeave, tooltipVisible } =
useEnterLeaveHandlers<HTMLDivElement>();
const [referenceElement, setReferenceElement] = useState<HTMLDivElement | null>(null);
const { image_url, thumb_url, title, title_link } = linkPreview;
const { image_url, thumb_url, title } = linkPreview;

if (
!LinkPreviewsManager.previewIsLoaded(linkPreview) &&
!LinkPreviewsManager.previewIsLoading(linkPreview)
)
return null;

const previewImageSrc = title_link || image_url || thumb_url;
const previewImageSrc = image_url || thumb_url;
return (
<div
className={clsx('str-chat__link-preview-card', {
Expand Down
54 changes: 54 additions & 0 deletions src/components/MessageComposer/__tests__/LinkPreviewList.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,60 @@ describe('LinPreviewCard', () => {
});
expect(screen.queryByTestId(LINK_PREVIEW_TEST_ID)).not.toBeInTheDocument();
});
it('uses image_url as the thumbnail source, never title_link', async () => {
const { channel, client } = await setup();
await renderLinkPreviewCard({
channel,
client,
linkPreview: generateScrapedImageAttachment(
fromPartial<Partial<Attachment>>({
image_url: 'https://example.com/image.png',
status: LinkPreviewStatus.LOADED,
thumb_url: 'https://example.com/thumb.png',
title_link: 'https://example.com/page',
}),
),
});
expect(screen.getByTestId('str-chat__base-image')).toHaveAttribute(
'src',
'https://example.com/image.png',
);
});
it('falls back to thumb_url when the preview has no image_url', async () => {
const { channel, client } = await setup();
await renderLinkPreviewCard({
channel,
client,
linkPreview: generateScrapedImageAttachment(
fromPartial<Partial<Attachment>>({
image_url: undefined,
status: LinkPreviewStatus.LOADED,
thumb_url: 'https://example.com/thumb.png',
title_link: 'https://example.com/page',
}),
),
});
expect(screen.getByTestId('str-chat__base-image')).toHaveAttribute(
'src',
'https://example.com/thumb.png',
);
});
it('renders no thumbnail when the preview has only a title_link', async () => {
const { channel, client } = await setup();
await renderLinkPreviewCard({
channel,
client,
linkPreview: generateScrapedImageAttachment(
fromPartial<Partial<Attachment>>({
image_url: undefined,
status: LinkPreviewStatus.LOADED,
thumb_url: undefined,
title_link: 'https://example.com/page',
}),
),
});
expect(screen.queryByTestId('str-chat__base-image')).not.toBeInTheDocument();
});
it('allows to dismiss a preview', async () => {
const { channel, client } = await setup();
const dismissPreviewMock = vi.spyOn(
Expand Down
Loading