Repository navigation
feat(ui): add the numericXxl text style for the xl badge count - #191
Merged
Merged
Conversation
The design's numeric/2xl style: bold, lg font size, 100% line height. StreamBadgeCountSize.xl now uses it instead of headingMd. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #191 +/- ##
==========================================
+ Coverage 68.65% 68.67% +0.02%
==========================================
Files 213 213
Lines 8757 8761 +4
==========================================
+ Hits 6012 6017 +5
+ Misses 2745 2744 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
xsahil03x
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submit a pull request
Linear: FLU-797
Github Issue: #
CLA
Description of the pull request
Follow-up to #189 (review comment). That PR drew
StreamBadgeCountSize.xlinheadingMdbecause there was no numeric style at that size. The design has one:numeric/2xl.This adds it as
StreamTextTheme.numericXxland uses it for the xl badge count.numericXxl(new)lg(20 iOS / 18 Android)headingMd(was used)lgWeight: the Figma variable says semi-bold (600), but upstream
design-system-tokensdefinesnumeric/2xlas bold, like the rest of the numeric scale. This follows upstream.Covered by the existing badge goldens. The xl badge count golden changes and needs regenerating through the
update_goldensworkflow.Screenshots / Videos
Golden diff to follow from
update_goldens.🤖 Generated with Claude Code