Skip to content

add REACT_APP_NAME to env sample - #45

Open
ethanppl wants to merge 3 commits into
gitstartfrom
fix-client-env
Open

ethanppl wants to merge 3 commits into
gitstartfrom
fix-client-env

Conversation

@ethanppl

@ethanppl ethanppl commented Nov 8, 2021

Copy link
Copy Markdown

Some users log path in client\src\components\Settings\AppForm.tsx, becomes ~/.config/undefined/logs/main.log.

Code in client\src\components\Settings\AppForm.tsx:

    const appName = process.env.REACT_APP_NAME;
    const platform = (window as any).platform;

    const linuxPath = `~/.config/${appName}/logs/main.log`;
    const macOSPath = `~/Library/Logs/${appName}/main.log`;
    const windowsPath = `%USERPROFILE%\\AppData\\Roaming\${appName}\\logs\\main.log`;

@ethanppl
ethanppl requested a review from ziahamza November 8, 2021 15:10
@ziahamza
ziahamza removed their request for review May 3, 2022 09:40

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant