Repository navigation
App engine hello world example too many dependencies #1247
Description
Hello, the hello app engine hello world seems to depend on express. Please remove the dependency, as hello world should always be as succinct as possible for pedagogical purposes!
Is google-cloud/nodejs-repo-tools even strictly necessary?
const http = require('http');
const PORT = process.env.PORT || 8080;
const server = http.createServer((request, response) => {
console.log(request.url);
response.end('Hello Node.js Server!');
});
server.listen(PORT, err => {
console.log(`App listening on port ${PORT}`);
console.log('Press Ctrl+C to quit.');
});
Metadata
Metadata
Assignees
Labels
No labels
Activity
fhinkel commentedon Apr 24, 2019
I agree,
npm installtakes a long time considering this is just hello-world.We use
@google-cloud/nodejs-repo-toolsfor the tests. We're in the process of simplifying this.quantuminformation commentedon May 25, 2019
Also points to deprecated npm install -g @google-cloud/functions-emulator
and doesn't inform you how to set the project: ie
quantuminformation commentedon May 25, 2019
But thanks for these examples, glad I don't have to depend on Serverless framework now, just another layer than can go wrong.
grant commentedon Jun 11, 2019
@ace-n, can you look at the
@google-cloud/functions-emulatordependency? Is that effort tracked somewhere?ace-n commentedon Jun 11, 2019
This is more-or-less tracked in #1333. (Right now, this is blocked on fully updating the
functionstests per [Google internal] b/134942934. Once that's done, it would probably only take 1-2 reasonable-sized PRs.)This is also vaguely on my radar. My task queue is currently 100% full however, so it'll likely be at least a few weeks before I have time to look at this. (You're welcome to beat me to it, of course.)
fhinkel commentedon Jul 16, 2019
I'm working on removing
nodejs-repo-toolsfor testinghello-world