Skip to content

run/markdown-preview/editor: Can successfully make a request to the Renderer failed #1987

Closed
Closed
run/markdown-preview/editor: Can successfully make a request to the Renderer failed#1987
Assignees
grayside
Labels
api: runIssues related to the Cloud Run API.priority: p2Moderately-important priority. Fix may not be included in next release.samplesIssues that are directly related to samples.status: blockedResolving the issue is dependent on other work.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Description

@flaky-bot
flaky-bot
bot
opened on Sep 28, 2020

Note: #1935 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.

commit: a3e0e4a
buildURL: Build Status, Sponge
status: failed

Test output
Response code 500 (Internal Server Error)
HTTPError: Response code 500 (Internal Server Error)
    at Request. (node_modules/got/dist/source/as-promise/index.js:117:42)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)

Activity

  1. flaky-bot
    added
    buildcop: issue
    priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    on Sep 28, 2020
  2. product-auto-label
    added
    api: runIssues related to the Cloud Run API.
    samplesIssues that are directly related to samples.
    on Sep 28, 2020
  3. flaky-bot
    added
    buildcop: flaky
    on Sep 29, 2020

  4. flaky-bot commented on Sep 29, 2020

    @flaky-bot
    flaky-botBot
    on Sep 29, 2020
    Author

    Looks like this issue is flaky. 😟

    I'm going to leave this open and stop commenting.

    A human should fix and close this.

    When run at the same commit (a3e0e4a), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

  5. grayside commented on Oct 1, 2020

    @grayside
    grayside
    on Oct 1, 2020
    Collaborator

    Confirmed this is a flaky test, in that the test passes locally. The current implementation of e2e test code for Cloud Run samples in this repo is a mess and needs more retry logic. Going to put together a brief proposal on an overhaul.

  6. grayside
    self-assigned this
    on Oct 1, 2020
  7. yoshi-automation
    added
    🚨This issue needs some love.
    on Oct 5, 2020

  8. grayside commented on Oct 6, 2020

    @grayside
    grayside
    on Oct 6, 2020
    Collaborator

    This flaky test is not blocking PRs, though conceivably it is driving very occasional retests.

    The correct solution is to ship a fix for #1991 and see how this goes.

  9. grayside
    added
    status: blockedResolving the issue is dependent on other work.
    priority: p2Moderately-important priority. Fix may not be included in next release.
    and removed
    priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.
    on Oct 6, 2020
  10. yoshi-automation
    removed
    🚨This issue needs some love.
    on Oct 6, 2020

  11. averikitsch commented on Nov 5, 2020

    @averikitsch
    averikitsch
    on Nov 5, 2020
    Contributor

    Closed via PR #2042

  12. averikitsch
    closed this as completedon Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: runIssues related to the Cloud Run API.priority: p2Moderately-important priority. Fix may not be included in next release.samplesIssues that are directly related to samples.status: blockedResolving the issue is dependent on other work.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions