Skip to content

chore(GAE Python3): add HTTP retries to flaky test - #8882

Merged
ace-n merged 3 commits into
mainfrom
fix-8852
Jan 13, 2023
Merged

ace-n merged 3 commits into
mainfrom
fix-8852

Conversation

@ace-n

@ace-n ace-n commented Jan 9, 2023 •

Copy link
Copy Markdown

Fixes #8852

@engelke I'd argue we should apply this change to other GAE Python 3 samples too, to prevent future flakiness. WDYT?

@ace-n
ace-n requested review from a team as code owners January 9, 2023 23:01
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Jan 9, 2023
@ace-n ace-n assigned engelke and unassigned leahecole Jan 9, 2023

@engelke engelke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ace-n ace-n added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 10, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 10, 2023
@ace-n ace-n added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 10, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 10, 2023
@ace-n

ace-n commented Jan 13, 2023

Copy link
Copy Markdown
Author

All required builds are passing, so I'll go ahead and merge.

(Python 3.11 hasn't yet completed, but it's not required for App Engine Python 3 samples.)

@ace-n
ace-n merged commit bb1c1df into main Jan 13, 2023
@ace-n
ace-n deleted the fix-8852 branch January 13, 2023 01:48
telpirion pushed a commit that referenced this pull request Mar 13, 2023
* chore(GAE Python3): add HTTP retries to flaky test

Fixes #8852

* Use backoff + requests.raise_for_status()

* Propagate changes to other samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

appengine.standard_python3.bundled-services.blobstore.django.main_test: test_upload_and_view failed

5 participants