Repository navigation
Upgrade google-http-client to eliminate deprecated usage - #1882
Merged
Merged
Conversation
5 tasks done
TadCordle
reviewed
Aug 1, 2019
TadCordle
approved these changes
Aug 1, 2019
chanseokoh
added a commit
that referenced
this pull request
Aug 19, 2019
…)" This reverts commit 61ff620.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1434.
Finally, google-http-client 1.31 is release, and we can move to the new world. jib-core will be once again free from any deprecated usage.
As noted in #1434, we no longer need to take care of
http(s).username|passworldproperties on our own. Note that I had previously committed a test for this in #1809, so we can rest assured that this continues to work.