Repository navigation
New HTTP framework to incorporate automatic insecure connection handling - #2100
Merged
Merged
Conversation
TadCordle
reviewed
Oct 28, 2019
TadCordle
left a comment
Contributor
There was a problem hiding this comment.
This mostly LGTM, I think others should take a look though since it seems like an important change.
briandealwis
left a comment
Member
There was a problem hiding this comment.
Still looking, but some early comments
briandealwis
left a comment
Member
There was a problem hiding this comment.
Sorry haven't finished. But some more things.
briandealwis
reviewed
Nov 1, 2019
briandealwis
approved these changes
Nov 1, 2019
loosebazooka
reviewed
Nov 1, 2019
This was referenced Nov 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing thread-safe
TlsFailoverHttpClient(still namedConnectionfor now) designed to be instantiated as a singleton stateful instance throughout the Jib build life cycle.The TLS failover feature is decoupled from
RegistryEndpointCallerand integrated intoTlsFailoverHttpClient. The new client provides a complete abstraction for taking care of all possible TLS failover scenarios and controlling whether to send credentials over plain-HTTP.RegistryAuthenticatorwill make use of the new client, so this will fix #2074.In the future, this setup will allow
Connectionalways creates a new HttpTransport for each HTTP call, creating a new connection pool each time. But this might be intended, I don't know. Not changing this behavior now.