Skip to content

Expose AbstractDependencyFilter from internal to public - #1538

Merged
Goooler merged 1 commit into
mainfrom
g/22050723/dependency-filter-default
Jul 23, 2025
Merged

Goooler merged 1 commit into
mainfrom
g/22050723/dependency-filter-default

Conversation

@Goooler

@Goooler Goooler commented Jul 23, 2025 •

Copy link
Copy Markdown
Member

@Goooler
Goooler requested a review from Copilot July 23, 2025 08:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR exposes the AbstractDependencyFilter class from the internal package to the public API, making it available as a nested class within DependencyFilter. The change enables external users to extend the abstract dependency filter functionality.

  • Moves AbstractDependencyFilter from internal package to public API as a nested class
  • Updates existing internal implementations to use the new public location
  • Documents the change in the changelog with the new public access path

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/DependencyFilter.kt Adds AbstractDependencyFilter as a public nested class with additional imports
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/MinimizeDependencyFilter.kt Updates inheritance to use the new public DependencyFilter.AbstractDependencyFilter
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/DefaultDependencyFilter.kt Updates inheritance to use the new public DependencyFilter.AbstractDependencyFilter
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/AbstractDependencyFilter.kt Removes the entire internal implementation (file deleted)
docs/changes/README.md Documents the API change in the unreleased section
api/shadow.api Updates the public API signature file to include the new public class

@Goooler
Goooler enabled auto-merge (squash) July 23, 2025 08:58
@Goooler
Goooler merged commit e18dde6 into main Jul 23, 2025
@Goooler
Goooler deleted the g/22050723/dependency-filter-default branch July 23, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants