Repository navigation
USB-C port: drop a delayed state change after a newer one - #489
Open
abhinav-jhanwar wants to merge 1 commit into
Open
abhinav-jhanwar wants to merge 1 commit into
abhinav-jhanwar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Going from Charging-only to On disables the ports and enables them 1.5 s later. A change to Off within that time is overridden by the delayed enable. So, data comes back and deny_new_usb2 goes to 0 while the setting shows Off.
Reproduced on a Pixel 8a with 2026110200: On and Off 0.96 s apart, then ports_enabled 0.55 s after Off. The delayed task now also checks that no newer port state change was made.
Steps to reproduce:
The USB is enabled even though the setting is set to Off.