Repository navigation
MS-407 · SM: Meet the Team - #587
Merged
Merged
Conversation
The two SM frames (5681:1281, 5685:18775) are states of one accordion: one department open at a time, its members in a snapping row that swipes natively, with arrows once the row overflows. Frames keep the LG per-department widths (FRAME_WIDTH, now exported) scaled to 160 tall. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the SM (<640px) Meet the Team section as a department switcher
🎫 Issue #580.
🎨 Figma Link:
SM Directors open
5681:1281, Tech open5685:18775▶ Changelist:
mobile/MobileTeam.tsx(new): the two SM frames are two states of one accordion (this answers the ticket's step 1, "what do the two frames represent"). Departments are listed in Figma's order (Directors, Tech, Design, Marketing, Sponsorship, Operations). Directors starts open. One department is open at a time, and clicking the open one closes it.CarouselArrow+useHorizontalGallery) appear only when the row overflows.departmentFramesinteam.ts). Widths come fromFRAME_WIDTH, scaled so every frame is 160 tall as in Figma; rect frames get an explicitaspectso they stay portrait.scenes/team/TeamScene.tsx: exportsFRAME_WIDTH(no other change), so SM and LG/MD share one table.public/team/sm/chevron.svg,linkedin.svg(new): Figma's chevron and LinkedIn glyph. Nothing matching existed inpublic/.team/sm/floor.svg(baseboard + floor + bench). Below 402px it scales down. Above 402px, the baseboard and floor colors carry on to the edges so the bench isn't repeated.page.tsx: renders<MobileTeam />in the SM tree, afterMobileValues.📝 Notes + 🚧 TODO:
linkedinUrl. None do yet (TODO inteam.ts), so no icons show today.id="team"on the section: same asMobileHero. The LG/MDSceneFrameowns that anchor and both trees are in the DOM. SM anchors are part of MS-502./dev/mobile?section=team: I left it out to avoid colliding with whichever SM ticket creates that page. The section shows on/below 640px.page.tsxwill conflict trivially with MS-405, which adds Speakers/Testimonials to the same list.🧪 Testing:
npx tsc --noEmit -p apps/mainpasses. The pre-commit hook passed:yarn build,yarn formatandyarn lint, with no new warnings.aria-expanded/aria-controls.#teamid.🎥 Screenshots & Screencasts:
🤖 Generated with Claude Code