Skip to content

Feature request: use system properties by default for proxy settings #813

Open

Description

@danielflower

I have a use case where I need to control whether or not to use a proxy using system properties, without having access to the code.

If org.htmlunit.HttpWebConnection#createHttpClientBuilder() set builder.useSystemProperties(); ("Use system properties when creating and configuring default implementations") this works.

This sets more than just proxy config according to https://issues.apache.org/jira/browse/HTTPCLIENT-1128 it sets:

ssl.TrustManagerFactory.algorithm
javax.net.ssl.trustStoreType
javax.net.ssl.trustStore
javax.net.ssl.trustStoreProvider
javax.net.ssl.trustStorePassword
java.home
ssl.KeyManagerFactory.algorithm
javax.net.ssl.keyStoreType
javax.net.ssl.keyStore
javax.net.ssl.keyStoreProvider
javax.net.ssl.keyStorePassword
http.proxyHost
http.proxyPort
http.nonProxyHosts
http.keepAlive
http.maxConnections

Personally I would like this on by default in HtmlUnit. But having a config option to set this would be useful too.

Activity

  1. rbri commented on Jul 28, 2024

    @rbri
    Member

    @danielflower sorry this did not make it into the release, will work on this for the next one

  2. rbri commented on Jul 28, 2024

    @rbri
    Member

    just thinking about having our own properties and an similar implementation as in the http client. To be independent from the HttpClient - but maybe this is a bit overcomplicated.

  3. rbri commented on Sep 5, 2024

    @rbri
    Member

    Sorry for being not that responsive during the last days - was on a workshop and will be out for two more weeks to have a holiday break. Afterwards we can work together to get this finally done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions