Use absolute issue links and link open-question issues - #10
Merged
Merged
Conversation
Relative ../../issues links resolve under /blob/<branch>/ on GitHub and return 404. Point them at the repository URL, matching the issue templates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
docs/open-questions.md, were relative (../../issues/new…). GitHub resolves those under/blob/<branch>/, so they returned 404. They now use the full repository URL, matching the issue templates.docs/open-questions.mdnow links each question to its issue instead ofIssue: TBD:catalog_ref) belong in 3.0? #3 · OQ-3 OQ-3 — Cross-channel guarantee comparability is unsolved #4 · OQ-4 OQ-4 — The format registry has no entries foraudio/*,ctv/*ordooh/*#5 · OQ-5 OQ-5 — Is amin_line_itemsfield needed? #6 · OQ-6 OQ-6 — Shouldpayment_termsandinvoicing_partybe catalog references? #7 · OQ-7 OQ-7 —environments[]needs validation against real inventory #8open-questionlabel.Type
Editorial. No change to
spec/.Checks
Examples parse,Issue forms parseandAppendix A matches the bodypass on the branch.Please merge with Create a merge commit to keep the two commits separate.