Skip to content

Implement support for Client-Side Token Generation - #17

Merged
dcaunt merged 1 commit into
mainfrom
dave/cstg
May 2, 2024
Merged

Implement support for Client-Side Token Generation#17
dcaunt merged 1 commit into
mainfrom
dave/cstg

Conversation

@dcaunt

@dcaunt dcaunt commented Apr 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

To test with a local operator, run

plutil -replace UID2ApiUrl -string "http://localhost:8080" Development/UID2SDKDevelopmentApp/UID2SDKDevelopmentApp/Info.plist
  • Add support for CSTG via a new method UID2Manager.generateIdentity(_:subscriptionID:serverPublicKey:appName:)
  • Add new dependencies required for parsing and generating ASN1 DER public keys.
  • Implement Hashable/Sendable on some value types

TODO

  • Final testing against completed server implementation
  • Update subscription ID and server public keys for dev app
  • Update PrivacyInfo.xcprivacy

@dcaunt
dcaunt marked this pull request as draft April 16, 2024 22:10
@dcaunt
dcaunt force-pushed the dave/cstg branch 2 times, most recently from be1126b to 484dd61 Compare April 22, 2024 08:45
@dcaunt
dcaunt marked this pull request as ready for review April 22, 2024 08:53
@dcaunt dcaunt changed the title [WIP] Client-Side Token Generation Implement support for Client-Side Token Generation Apr 22, 2024
IanDBird
IanDBird reviewed Apr 22, 2024
View reviewed changes

@IanDBird IanDBird left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of observations, but looks great!

Comment thread Development/UID2SDKDevelopmentApp/UID2SDKDevelopmentApp/RootViewModel.swift Outdated
Comment thread Development/UID2SDKDevelopmentApp/UID2SDKDevelopmentApp/RootViewModel.swift
Comment thread Sources/UID2/CryptoUtil.swift Outdated
Comment thread Development/UID2SDKDevelopmentApp/UID2SDKDevelopmentApp/RootView.swift
@dcaunt dcaunt mentioned this pull request Apr 24, 2024
Merged
@dcaunt
dcaunt force-pushed the dave/cstg branch 5 times, most recently from fa6e885 to d13de56 Compare April 30, 2024 12:17
IanDBird
IanDBird previously approved these changes Apr 30, 2024
View reviewed changes

@IanDBird IanDBird left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Awesome work!

@dcaunt
dcaunt merged commit 234e510 into main May 2, 2024
@dcaunt
dcaunt deleted the dave/cstg branch May 2, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@IanDBird IanDBird IanDBird approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dcaunt @IanDBird