Repository navigation
[FEATURE] News: Add Container Object News Period Setting - #11920
matheuszych wants to merge 3 commits into
Conversation
|
Hey @alex40724, I would kindly ask you to take a quick look at the changes, as part of the PR affects one of your components. Please also let me know if you do or do not have any particular concerns about the changes in that area, since the code is related to the News component rather than the Container component. We are currently planning to consolidate all code belonging to the News component that is currently distributed across other components. Our goal is to move this code back into the News domain with the next trunk version and provide only a few well-defined interfaces for other components to consume. This should reduce the overlap in PRs of this kind in the future. Best regards, |
c7b4eb4 to
5a1aa2a
Compare
|
In #12163 I've suggested a rewording of the news_hide_news_per_date family - the label is now „Startdatum für Neuigkeiten" and the info line reads „Neuigkeiten werden erst ab einem bestimmten Datum angezeigt. Ältere Neuigkeiten werden ausgeblendet." Since this PR adds the new radio family (news_hide_news_mode / _none / _global / _by_period) right next to those, we might want to align our proposed changes to see that the styles match? |
|
Hello @Chris-Squirrel , If you share the exact wording you have in mind for each variable, I’d be happy to make the adjustments. Best regards |
Chris-Squirrel
left a comment
There was a problem hiding this comment.
Some suggestions for tweaks to the English / harmonisation with my recent PR.
| news#:#news_hide_news_by_period_info#:#Only news that are in the given period will be displayed. | ||
| news#:#news_hide_news_date#:#Starting Date | ||
| news#:#news_hide_news_global#:#Use global setting | ||
| news#:#news_hide_news_mode#:#Limit news display |
There was a problem hiding this comment.
This has to be in title case. I would also like to suggest something more exact.... like 'Time-Based News Restriction' - this brings it closer to the German too.
| news#:#news_hide_news_global#:#Use global setting | ||
| news#:#news_hide_news_mode#:#Limit news display | ||
| news#:#news_hide_news_none#:#Do not limit news | ||
| news#:#news_hide_news_per_date#:#Show News After |
There was a problem hiding this comment.
Ok - this is interesting. I suggested changing this in my PR to 'news#:#news_hide_news_per_date#:#Start Date for News'. In light of your changes to where this label is shown, however, we will need to change it to sentence case in English. As this is now a radio button option, I think we can be a bit longer and maybe even drop the info line? How about: "Show news starting from a specific date"?
| news#:#news_hide_news_mode#:#Limit news display | ||
| news#:#news_hide_news_none#:#Do not limit news | ||
| news#:#news_hide_news_per_date#:#Show News After | ||
| news#:#news_hide_news_per_date_info#:#Only news that are newer than a certain date will be displayed. |
There was a problem hiding this comment.
I believe we can now drop this info line.
| news#:#news_hide_news_date#:#Starting Date | ||
| news#:#news_hide_news_global#:#Use global setting | ||
| news#:#news_hide_news_mode#:#Limit news display | ||
| news#:#news_hide_news_none#:#Do not limit news |
There was a problem hiding this comment.
How about: "Do not restrict news"?
| news#:#news_get_priv_feed_title#:#Personal private Feed-URL | ||
| news#:#news_hide_news_block#:#Hide News Block | ||
| news#:#news_hide_news_block_info#:#Hide block in learner's view. The news block will only be visible for users with write permission. | ||
| news#:#news_hide_news_by_period#:#Show News by Period |
There was a problem hiding this comment.
Suggestion: Show news from the last week, month or year - and drop the info line(?)
| news#:#news_cache_info#:#Update news blocks all x minutes. ‘0’ means every time. Higher values improve performance, but news may link to non-accessible items. | ||
| news#:#news_default_visibility#:#Default Access | ||
| news#:#news_co_period#:#Container-Objects News Period | ||
| news#:#news_co_period_info#:#Defines the time period used for news in Container-Objects. Select lower values, if you experience any performance problems. |
There was a problem hiding this comment.
How about: Select the default period for which news is displayed in container-objects. This setting can be overridden for each object individually. Select a shorter period if you experience performance problems.
| news#:#news_cache#:#News Cache (Minutes) | ||
| news#:#news_cache_info#:#Update news blocks all x minutes. ‘0’ means every time. Higher values improve performance, but news may link to non-accessible items. | ||
| news#:#news_default_visibility#:#Default Access | ||
| news#:#news_co_period#:#Container-Objects News Period |
There was a problem hiding this comment.
Slightly more natural sounding: News Period for Container-Objects
| news#:#news_default_visibility#:#Default Access | ||
| news#:#news_co_period#:#Container-Objects News Period | ||
| news#:#news_co_period_info#:#Defines the time period used for news in Container-Objects. Select lower values, if you experience any performance problems. | ||
| news#:#news_container_object_visibility_settings#:#Visibility Settings of News on Container-Objects |
There was a problem hiding this comment.
Visibility Settings of News in Container-Objects
| news#:#news_rss_title_format_news_obj#:#News Headline (Object Title) | ||
| news#:#news_rss_title_format_obj_news#:#Object Title - News Headline | ||
| news#:#news_settings#:#News Settings | ||
| news#:#news_settings#:#General Settings of News |
There was a problem hiding this comment.
This variable is used in three locations I think. I don't feel that 'General' is really accurate when a user edits the news block on their dashboard...?
See: https://docu.ilias.de/go/wiki/wpage_8964_1357 Added a global container-object news period and per-container hide modes (global, none, per date, by period). Replaced the checkbox-only date filter with a radio group in `ilContainerNewsSettingsGUI`, extended `NewsCollectionService` to apply the selected mode when loading news, and added the related administration settings and language strings.
See: https://docu.ilias.de/go/wiki/wpage_8964_1357 Grouped the administration news settings into separate sections for dashboard and container-object visibility. Moved the container news period below its own header and updated related language strings for the new section titles and labels.
5a1aa2a to
d40678e
Compare
|
Hello @Chris-Squirrel , I applied your suggestions as a separate commit for now. @oliversamoila @thojou Please also take a look and let me know if that’s okay with you. Best regards |
oliversamoila
left a comment
There was a problem hiding this comment.
Thanks @Chris-Squirrel and @matheuszych.
Additional changes approved.
See: https://docu.ilias.de/go/wiki/wpage_8964_1357
Added a global container-object news period and per-container hide modes (global, none, per date, by period). Replaced the checkbox-only date filter with a radio group in
ilContainerNewsSettingsGUI, extendedNewsCollectionServiceto apply the selected mode when loading news, and added the related administration settings and language strings.