Repository navigation
KioskMode: enhanced docu (#23574) and fixed param to TOCBuilder - #1202
Merged
Merged
Conversation
`end` will have no visual representation in a table of contents and just marks the end of a node. Hence it can't use any command.
Contributor
|
I still don't get the Why is this an integer? Let's suppose I will build a next control... |
Contributor
Author
|
Maybe you already want to encode the next chapter in the "next"-control. Then you might just set the parameter to the index of the chapter. This is just a convenience, you could get the same effect by using the state. If you think it is useless, we also might remove it completely. Maybe my problems explaining the purpose to you implies just that =) |
Member
|
Jour Fixe, 08 OCT 2018 : We accept this PR for 5.4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some clarifications in the docu according to https://mantis.ilias.de/view.php?id=23574.
I also removed a bogus parameter to
TOCBuilder::end. Although this change is minor, this is also a breaking change, thus I'll add this to JF-agenda.