Skip to content

COMP: Fix the test link when ITK is built with wrapping enabled #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vboussot merged 2 commits into from
Sep 17, 2026
Merged

COMP: Fix the test link when ITK is built with wrapping enabled #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3aa5e0b
COMP: Link the test drivers with the keyword signature
hjmjohnson Sep 17, 2026
38b400a
COMP: Keep --no-as-needed off linkers that reject it
hjmjohnson Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,13 @@ function(impact_link_python_embed target)
set(_impact_pylib ${IMPACT_PYTHON_EMBED_LIBRARY})
endif()
if(_impact_pylib)
target_link_libraries(${target} -Wl,--no-as-needed ${_impact_pylib} -Wl,--as-needed)
# --no-as-needed is GNU-ld only; Apple's linker rejects it outright and
# never drops a needed library anyway.
if(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang" AND NOT APPLE AND NOT MSVC)
target_link_libraries(${target} PRIVATE -Wl,--no-as-needed ${_impact_pylib} -Wl,--as-needed)
else()
target_link_libraries(${target} PRIVATE ${_impact_pylib})
endif()
endif()
endfunction()

Expand Down Expand Up @@ -97,7 +103,7 @@ if(NOT TARGET GTest::GTest)
endif()

add_executable(ImpactGTestDriver itkImpactBackendGTest.cxx)
target_link_libraries(ImpactGTestDriver ${Impact-Test_LIBRARIES} Impact GTest::GTest)
target_link_libraries(ImpactGTestDriver PRIVATE ${Impact-Test_LIBRARIES} Impact GTest::GTest)
impact_link_python_embed(ImpactGTestDriver)
# The ImpactConvexAdam.RealLungCT* gtest runs on a real lung-CT pair (and the M258 model)
# kept out of git. Fetch them via ITK ExternalData from the committed .sha512 content links
Expand Down
Loading