Skip to content

Add tooling to send email to ci_failure email list on ci failure - #351

Merged
stumbo merged 2 commits into
mainfrom
bs35_new_bib_type_transcript
Oct 15, 2026
Merged

stumbo merged 2 commits into
mainfrom
bs35_new_bib_type_transcript

Conversation

@stumbo

@stumbo stumbo commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

Updates unwatched CI processes to provide feedback on failure.

On failure an email is sent to the interlisp.org group ci_failures. An example message with the current build failure:

CI workflow FAILED for Interlisp/Interlisp.github.io.

Workflow: github pages
Event: pull_request
Ref: refs/pull/351/merge (351/merge)
SHA: 8123d7beb0620a75f6525443baae817069839261
Actor: stumbo
Run: https://github.com/Interlisp/Interlisp.github.io/actions/runs/38298705101

Job results:
  validate-docs: success
  hugo-version: success
  build: failure (skipped=false, has-warnings=)
  preview: skipped
  deploy: skipped

Please review the failed run logs at the URL above.

Updates unwatched CI processes to provide feedback on failure.
@stumbo
stumbo marked this pull request as ready for review October 14, 2026 11:59
@stumbo stumbo self-assigned this Oct 14, 2026

@pamoroso pamoroso left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea how to test this but it looks useful and reasonable.

@masinter

Copy link
Copy Markdown
Member

testing the code to respond to a failure of workflow is likely to risk a stack overflow or infinite loop.
So i think we have to just merge this and test it after install.
Back it out if it doesn't behave as expected.

@hjellinek

hjellinek commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Who will send the failure emails. That is, what address?

I ask because the ci_failures group currently won't accept email sent from non-interlisp.org addresses. I can fix that if you want me to.

@hjellinek

Copy link
Copy Markdown
Contributor

Who will send the failure emails. That is, what address?

I ask because the ci_failures group currently won't accept email sent from non-interlisp.org addresses. I can fix that if you want me to.

@stumbo just told me that the email is sent from an @interlisp.org bot address, so no need to change anything.

@interlisp-staging-bot

Copy link
Copy Markdown

Staging preview for this pull request is available at https://interlisp.github.io/Interlisp.staging/pr-351/

@stumbo

stumbo commented Oct 15, 2026

Copy link
Copy Markdown
Member Author

Perfect - the build failed and sent the expected notice on the initial PR because the issue with Zotero was still broken. Once PR 350 was merged into main and main was merged into this PR, fixing the Zotero issue, it completed deployed the staging site and did not send a failure note.

We tested the two conditions we're interested in - generating emails on failures and not skipping the email step when the build works correctly.

@stumbo
stumbo merged commit f8c534f into main Oct 15, 2026
6 checks passed
@stumbo
stumbo deleted the bs35_new_bib_type_transcript branch October 15, 2026 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants