Skip to content

Test dijkstra - #6716

Merged
palas merged 11 commits into
masterfrom
test-dijkstra
Nov 10, 2026
Merged

palas merged 11 commits into
masterfrom
test-dijkstra

Conversation

@palas

@palas palas commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Description

This PR modifies cardano-testnet to target Dijkstra instead of Conway. Currently it uses SRPs to the patched versions of cardano-ledger and ouroboros-network. We will update it to use the releases after bumping them in cardano-api and cardano-cli.

Also, this PR currently removes PlutusV2, because of a bug that is fixed in IntersectMBO/cardano-ledger#6030, we need to restore PlutusV2 once we use the last released versions of dependencies that patch it so that it shows up when starting in Dijkstra.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Running tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
    • cardano-node-chairman, cardano-submit-api and cardano-testnet instead need a
      changelog fragment in <package>/.changes/, because their CHANGELOG.md is generated
      from fragments at release time. Copy _TEMPLATE.yml from that directory, or run
      nix run github:input-output-hk/cardano-dev#herald -- new
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-9.6 and ghc-9.12
  • Self-reviewed the diff

@palas palas self-assigned this Oct 2, 2026
@palas
palas added this pull request to stack #6717 October 2, 2026 18:02
@palas
palas requested a review from a team as a code owner October 2, 2026 18:02
@palas
palas force-pushed the test-dijkstra branch 3 times, most recently from a245ceb to 5f7064a Compare October 5, 2026 15:48
Jimbo4350 added a commit that referenced this pull request Oct 5, 2026
…support

Temporarily point two dependencies at patched releases, the same commits
#6716 uses:

  * ouroboros-consensus at IntersectMBO/ouroboros-consensus@61cd7cec:
    the 4.2.1.0 release plus the cherry-picked
    IntersectMBO/ouroboros-consensus#2167 ("Allow hardfork into
    Dijkstra") and a fix so the db tools accept
    ExperimentalHardForksEnabled. No 4.x release contains these; without
    #2167 the Conway ledger config is built with
    TriggerHardForkNotDuringThisExecution and the node can never enter
    the Dijkstra era, so the "Hard fork to Dijkstra" test fails at the
    era assertion.
  * cardano-api at IntersectMBO/cardano-api@216c5256: the 11.7.0.0
    release plus IntersectMBO/cardano-api#1362 ("Add support for
    Dijkstra ledger events"). Without it the client-side ledger fold
    behind `EpochStateView` dies with a non-exhaustive pattern match on
    the first Dijkstra block, which is why the Dijkstra tests previously
    had to stop the view before the fork and poll the node through the
    CLI instead. With it the view follows the chain into Dijkstra, so the
    tests now wait for PV12 and read the Dijkstra `NewEpochState` through
    the view like every other test.

With these SRPs the "Hard fork to Dijkstra" test passes: the governance
hard fork to PV12 moves the node into Dijkstra and `query tip` reports
the Dijkstra era. The "Nested transaction swap" test reaches the Dijkstra
ledger and is rejected with SubBadInputsUTxO, because UTxO-HD key
fetching (getTransactionKeySets via allInputsTxBodyF) does not load
sub-transaction inputs in consensus 4.2.1.0; consensus main uses the
ledger's neededTxInsForBlock instead.

Replace with released versions once they are available.
Base automatically changed from generalise-for-dijkstra to master October 5, 2026 16:23
@palas
palas requested a review from Jimbo4350 October 5, 2026 16:30
@palas palas linked an issue Oct 8, 2026 that may be closed by this pull request
@palas
palas removed this pull request from stack #6717 October 8, 2026 17:31

@carbolymer carbolymer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should refactor this a bit more I think. LGTM overall.

@Jimbo4350 Jimbo4350 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few comments.

Comment thread cardano-testnet/src/Testnet/Defaults.hs Resolved
@palas
palas enabled auto-merge November 10, 2026 19:19
@palas
palas added this pull request to the merge queue Nov 10, 2026
@palas
palas removed this pull request from the merge queue due to a manual request Nov 10, 2026
@palas
palas added this pull request to the merge queue Nov 10, 2026
Merged via the queue into master with commit 9f9158b Nov 10, 2026
31 checks passed
@palas
palas deleted the test-dijkstra branch November 10, 2026 22:23
koslambrou added a commit that referenced this pull request Nov 16, 2026
Update the CHaP index-state to pick up ouroboros-consensus 5.4.0.1 and
require it in cardano-node (^>= 5.4.0.1). With the LSM backend, the time
a thread spends waiting for IO to complete is no longer accounted as
IOWAIT.

Bump cabal versions and compile changelogs from herald fragments:

- cardano-node 11.2.2
- cardano-node-chairman 11.2.2
- cardano-submit-api 11.2.2
- cardano-testnet 11.3.0: major bump for the breaking changes merged
  since 11.2.1 (#6637, #6716, #6769)
koslambrou added a commit that referenced this pull request Nov 16, 2026
Update the CHaP index-state to pick up ouroboros-consensus 5.4.0.1 and
require it in cardano-node (^>= 5.4.0.1). With the LSM backend, the time
a thread spends waiting for IO to complete is no longer accounted as
IOWAIT.

Bump cabal versions and compile changelogs from herald fragments:

- cardano-node 11.2.2
- cardano-node-chairman 11.2.2
- cardano-submit-api 11.2.2
- cardano-testnet 11.3.0: major bump for the breaking changes merged
  since 11.2.1 (#6637, #6716, #6769)
koslambrou added a commit that referenced this pull request Nov 16, 2026
Update the CHaP index-state to pick up ouroboros-consensus 5.4.0.1 and
require it in cardano-node (^>= 5.4.0.1). With the LSM backend, the time
a thread spends waiting for IO to complete is no longer accounted as
IOWAIT.

Bump cabal versions and compile changelogs from herald fragments:

- cardano-node 11.2.2
- cardano-node-chairman 11.2.2
- cardano-submit-api 11.2.2
- cardano-testnet 11.3.0: major bump for the breaking changes merged
  since 11.2.1 (#6637, #6716, #6769)
koslambrou added a commit that referenced this pull request Nov 16, 2026
Update the CHaP index-state to pick up ouroboros-consensus 5.4.0.1 and
require it in cardano-node (^>= 5.4.0.1). With the LSM backend, the time
a thread spends waiting for IO to complete is no longer accounted as
IOWAIT.

Bump cabal versions and compile changelogs from herald fragments:

- cardano-node 11.2.2
- cardano-node-chairman 11.2.2
- cardano-submit-api 11.2.2
- cardano-testnet 11.3.0: major bump for the breaking changes merged
  since 11.2.1 (#6637, #6716, #6769)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate cardano-testnet default era from Conway to Dijkstra

3 participants