Skip to content
This repository was archived by the owner on Nov 18, 2026. It is now read-only.

Add a missing term for (-qv*d(rho_zz)/dt) in updating theta_m tendency - #32

Merged
jjguerrette merged 1 commit into
JCSDA-internal:release-stablefrom
syha:bugfix/IAU_rthm
Jul 12, 2022
Merged

jjguerrette merged 1 commit into
JCSDA-internal:release-stablefrom
syha:bugfix/IAU_rthm

Conversation

@syha

@syha syha commented Jul 12, 2022 •

Copy link
Copy Markdown

MPAS computes tendencies for the model prognostic variables coupled with rho_zz (e.g., X = x * rho_zz).
As DA also updates the mass field, the updated rho_zz should be accounted for in the tendency updates with IAU.
But the current tendency for modified potential temperature (e.g., theta modified by qv) coupled with rho_zz, missed the changes in rho_zz (e.g., -qv*d(rho_zz)/dt), which is now added back into the atm_add_tend_anal_incr subroutine.

Successfully compiled in mpas-bundle, but has not been tested in the JEDI-MPAS cycling yet.
Once the MPAS-Workflow is updated to the YAMLS for the latest code, this bug fix can be tested in the cycling context.

@liujake liujake left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond my ability to review this bug fix, but fine with me to merge as it should not affect other applications without IAU.

@jjguerrette jjguerrette changed the title Add a missing term for (-qv*d(rho_zz)/dt) in updating the tendency fo… Add a missing term for (-qv*d(rho_zz)/dt) in updating theta_m tendency Jul 12, 2022
@jjguerrette

Copy link
Copy Markdown

@syha, do you prefer that I merge this PR now or wait until the cycling experiment is completed?

@syha

syha commented Jul 12, 2022

Copy link
Copy Markdown
Author

@jjguerrette, please go ahead and merge it now. Thanks!

@jjguerrette
jjguerrette merged commit 353b807 into JCSDA-internal:release-stable Jul 12, 2022
@jjguerrette

Copy link
Copy Markdown

My apologies to the group. I accidentally left the commit message blank. The title is informative though.

climbfuji pushed a commit that referenced this pull request Aug 26, 2022
@syha
syha deleted the bugfix/IAU_rthm branch September 10, 2022 03:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants