This repository was archived by the owner on Nov 18, 2026. It is now read-only.
Repository navigation
Add a missing term for (-qv*d(rho_zz)/dt) in updating theta_m tendency - #32
Merged
Merged
Conversation
liujake
approved these changes
Jul 12, 2022
liujake
left a comment
There was a problem hiding this comment.
Beyond my ability to review this bug fix, but fine with me to merge as it should not affect other applications without IAU.
|
@syha, do you prefer that I merge this PR now or wait until the cycling experiment is completed? |
Author
|
@jjguerrette, please go ahead and merge it now. Thanks! |
|
My apologies to the group. I accidentally left the commit message blank. The title is informative though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MPAS computes tendencies for the model prognostic variables coupled with rho_zz (e.g., X = x * rho_zz).
As DA also updates the mass field, the updated rho_zz should be accounted for in the tendency updates with IAU.
But the current tendency for modified potential temperature (e.g., theta modified by qv) coupled with rho_zz, missed the changes in rho_zz (e.g., -qv*d(rho_zz)/dt), which is now added back into the atm_add_tend_anal_incr subroutine.
Successfully compiled in mpas-bundle, but has not been tested in the JEDI-MPAS cycling yet.
Once the MPAS-Workflow is updated to the YAMLS for the latest code, this bug fix can be tested in the cycling context.