[rickgrubin-tomorrow]

Description

Add directory site-packages to pyiodautils install directory.

The pathing is a core design standard and supported by PEP 405 and PEP 427.

This change will also allow spack package recipes to set PYTHONPATH when creating module files.

Checklist

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have run the unit tests before creating the PR

[srherbener]

@rickgrubin-tomorrow thanks for submitting this fix. Let's review here in the public ioda repo. When this PR is ready for merge, I will clone this PR in the internal ioda repo and do the merge there. That should sync back up here in the public repo so you can have access. Once that occurs we can then close this PR.

[srherbener]

Thanks for finding this and fixing it. I completely agree with moving to the "site-packages" subdirectory.

Just want to check: there is another ioda python library called "pyioda" that is also not being installed in the "site-packages" subdirectory. Should this one also be moved?

ioda/src/engines/ioda/python/CMakeLists.txt

Lines 34 to 38 in aadc65c

	# AddPyLib will set the target file for _ioda_python to the subdirectory:
	#
	# lib/${pyver}/pyioda/ioda/_ioda_python.* # .* is the appropriate system suffix for
	# # a shared library
	#

We may need help/advice from @rhoneyager-tomorrow concerning pyioda.

[rickgrubin-tomorrow]

Thanks for finding this and fixing it. I completely agree with moving to the "site-packages" subdirectory.

Just want to check: there is another ioda python library called "pyioda" that is also not being installed in the "site-packages" subdirectory. Should this one also be moved?

ioda/src/engines/ioda/python/CMakeLists.txt

Lines 34 to 38 in aadc65c

	# AddPyLib will set the target file for _ioda_python to the subdirectory:
	#
	# lib/${pyver}/pyioda/ioda/_ioda_python.* # .* is the appropriate system suffix for
	# # a shared library
	#

We may need help/advice from @rhoneyager-tomorrow concerning pyioda.

Thanks @srherbener I missed this one -- this pathing should also be

AddPyLib(_ioda_python ioda ${pyver}/site-packages)

[srherbener]

Thanks!

[fmahebert]

Thanks @rickgrubin-tomorrow ; @srherbener I'll leave you to bring this into the internal repo.