Repository navigation
plan(tray-keep-alive): land the tray code that missed #1714 - #1800
Merged
Merged
Conversation
…closes Implements amended local ADR 0043 §5. Closing the main window hides it to a notification-area icon, so the process and its MCP listener keep answering. - MainWindowClosePolicy decides Hide or Quit. - ShellWindows handles AppWindow.Closing: when the policy says Hide, it cancels the close, flushes and hides. ActivateMainWindow shows the window first. - TrayIcon is hand-written Shell_NotifyIcon interop with an Open Backlog / Quit menu, double-click and Enter, a re-add on TaskbarCreated, and removal on exit. - A plain second launch is redirected to the running instance. A start by the sign-in startup task opens to the tray. - The first hide shows a one-time toast. Toast presses go through ActivateMainWindow. - WorkspaceSettingsStore gains KeepRunningInTray and TrayHintShown. - The MCP server settings page gains "Keep running in the tray when closed" and "Start Backlog when I sign in", through IStartupRegistration, which the MSIX StartupTask backs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…4 embed Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 10027f6)
…4b92-8d53-72cdfe58850d feat(desktop): keep the app running in the tray when the main window closes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This lands the tray keep-alive code on
main. #1714 mergedplan/tray-keep-aliveintomainat 16:05 on 10 Nov. #1712 merged into the plan branch afterwards, at 21:26, so its code never reachedmain. v0.1.143 and v0.1.144 therefore carry only the ADR 0043 amendment (#1709).What #1712 adds: closing the main window hides it to the notification area, and the process and MCP listener keep running. The tray icon has Open Backlog and Quit. A plain second launch is redirected to the running instance. On the MCP server settings page there are two switches, Keep running in the tray when closed (default on) and Start Backlog when I sign in (MSIX
StartupTask, default off). #1712's description has the full breakdown and the hand-validation checklist.Evidence
git merge-treeoforigin/mainwithorigin/plan/tray-keep-alive: no conflicts. The diff is the 3 commits of feat(desktop): keep the app running in the tray when the main window closes #1712 (18 files, +1,299 / −47).C4WorkspaceTestsfailures, both caused by ADR 0046 on the plan branch's older base.mainalready carries the C4 fixes (#1707), so they should pass here. This PR's own checks confirm it.Merge Danger
trayrow is written only when a value differs from its default.🤖 Generated with Claude Code