Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #292 +/- ##
==========================================
- Coverage 85.91% 85.37% -0.54%
==========================================
Files 18 18
Lines 1945 1942 -3
==========================================
- Hits 1671 1658 -13
- Misses 274 284 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The downgrade test resolved FunctionWrappers 1.0.0 and errored in every
testset that exercises a `CompiledTape` (ChainRulesTests, GradientTests,
JacobianTests, HessianTests):
LoadError: Module IR does not contain specified entry function
Stacktrace:
[1] assume @ FunctionWrappers/src/FunctionWrappers.jl:11 [inlined]
...
[5] forward_pass!(compiled_tape::ReverseDiff.CompiledTape{...})
@ ReverseDiff src/api/tape.jl:124
FunctionWrappers <= 1.1.1 defines `assume` with the pre-Julia-1.6 form of
`Base.llvmcall` in which the second element of the tuple is the function
body. Since v"1.6.0-DEV.663" Julia interprets that element as the name of
the entry function in the supplied module IR, so the call fails at run
time. FunctionWrappers 1.1.2 is the first release that branches on
`VERSION` and emits a named `@fw_assume` definition.
ReverseDiff therefore never worked with FunctionWrappers < 1.1.2 on any
Julia version we still support, so the lower bound was simply wrong.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.