Conversation
vchuravy
reviewed
Jun 22, 2026
|
|
||
| # Load REPL so that interactive use doesn't invalidate the precompiled compiler | ||
| # pipeline (fixed on Julia 1.14, see JuliaLang/julia#61714). | ||
| import REPL |
Member
There was a problem hiding this comment.
One idea I had is that ideally with would be a weak-dep, and we could use PrecompileTools to heal the invalidation there, but perhaps that is the perfect being the enemy of the good.
Member
Author
There was a problem hiding this comment.
"Healing" invalidations feels so wrong. Maybe I'm just not familiar enough with it.
If you don't mind I'll go ahead with this for now, as it should be fixed on 1.14 anyway.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #856 +/- ##
=======================================
Coverage 80.33% 80.34%
=======================================
Files 25 25
Lines 4775 4777 +2
=======================================
+ Hits 3836 3838 +2
Misses 939 939 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes JuliaGPU/Metal.jl#840