Warn when the pre-test init time becomes much slower than a worker restart - #183
Open
christiangnrd wants to merge 9 commits into
Open
christiangnrd wants to merge 9 commits into
christiangnrd wants to merge 9 commits into
Conversation
christiangnrd
added this pull request to stack #184
September 11, 2026 13:03
christiangnrd
force-pushed
the
slowwarn
branch
from
September 11, 2026 13:20
82d0b68 to
3bc5c39
Compare
Collaborator
|
Haven't looked at the code, I appreciate the idea, but that message so long feels a bit too much, probably a very brief explanation and a pointer to the docs would be better |
Collaborator
Author
I agree I'll fix it up in the near future |
giordano
reviewed
Sep 16, 2026
…start Under macOS memory pressure (issue #124), the full GC run before each test gets progressively slower on a long-lived worker, which is usually a sign that there are too many workers for the available memory and can lead to hangs or much longer test times. Track the init time of tests run on freshly spawned workers (which already includes spawn, init_worker_code and init_code, so it is the full cost of a restart) and, once a warm init exceeds SLOW_INIT_FACTOR times that, print a warning (once per run) suggesting to lower JULIA_TEST_MAXRSS_MB / max_worker_rss or the number of jobs. A testset forces a slow init to check the warning. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
christiangnrd
force-pushed
the
slowwarn
branch
from
September 16, 2026 00:31
3bc5c39 to
896ff0a
Compare
Collaborator
Author
|
@giordano This should be ready for final review. I improved the job selection docs so that the warning message has something to refer to, and I got rid of the pointless |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #182
Screenshots:
