Repository navigation
Share one package-version constant and test the MCP handshake version - #12
Open
coderyaz856 wants to merge 1 commit into
Open
coderyaz856 wants to merge 1 commit into
coderyaz856 wants to merge 1 commit into
Conversation
coderyaz856
force-pushed
the
Yazid-The-Tech-Alchemist
branch
from
October 10, 2026 22:38
8655a8d to
058b74a
Compare
Author
|
@MantisCartography Please review this change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #11
Context
Issue #11 identified that the MCP client reported the hardcoded version
3.1.0instead of the installed package version.Since this pull request was opened, PR #14 updated
mainso that the MCP client reads its version frompackage.json. After rebasing onto the latestmain, this pull request is now a cleanup and regression-testing contribution.Change
PACKAGE_VERSIONfromlib/utils/package-root.js.bin/mantis.jsandlib/impl/mcp-client-service.js.package.jsonreading logic.initializerequest and verifies thatclientInfo.versionmatches the package version.This gives the CLI and MCP client one source of truth for the package version and protects the handshake behavior against regression.
Testing
node --test: 22 of 22 tests pass.node bin/mantis.js --versionreturns3.7.0.node bin/mantis.js --helpworks correctly.git diff --check origin/main...HEADpasses.8a5163awith no remaining conflicts.Scope
No commands, configuration, authentication behavior, MCP headers, URLs, or user-facing output are changed.