Skip to content

(WIP) Add support for selecting different shading languages to high-level framework based samples - #1600

Draft
SaschaWillems wants to merge 28 commits into
KhronosGroup:mainfrom
SaschaWillems:slang_shaders2
Draft

SaschaWillems wants to merge 28 commits into
KhronosGroup:mainfrom
SaschaWillems:slang_shaders2

Conversation

@SaschaWillems

@SaschaWillems SaschaWillems commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

Description

In earlier PRs, I added support for loading shaders for different languages (glsl, hlsl, slang) to the samples based on my api framework. This PR aims to add the same to the high-level framework, so samples using that can now also use additional shading languages like Slang.

Refs #1385
Fixes #1602

Note: Work-in-progress

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

  • I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
  • For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
  • For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

@SaschaWillems SaschaWillems added the framework This is relevant to the framework label Nov 15, 2026
@SaschaWillems
SaschaWillems marked this pull request as draft November 15, 2026 12:09
…sample

Output a proper error message instead
Forcing broke batch runs/force batch run partially into using slang
Refs KhronosGroup#1602

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework This is relevant to the framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sample Raytracing Invocation Reorder forces Slang shaders - Breaking batch runs

1 participant