Repository navigation
(WIP) Add support for selecting different shading languages to high-level framework based samples - #1600
Draft
SaschaWillems wants to merge 28 commits into
Draft
(WIP) Add support for selecting different shading languages to high-level framework based samples#1600SaschaWillems wants to merge 28 commits into
SaschaWillems wants to merge 28 commits into
Conversation
Required for shading language selection
Required for caching
… selection works in api samples
Necessary as files have been moved
Necessary as files have been moved
Doesn't use famework functions
# Conflicts: # bldsys/cmake/template/sample/sample.cpp.in
…sample Output a proper error message instead Forcing broke batch runs/force batch run partially into using slang Refs KhronosGroup#1602
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In earlier PRs, I added support for loading shaders for different languages (glsl, hlsl, slang) to the samples based on my api framework. This PR aims to add the same to the high-level framework, so samples using that can now also use additional shading languages like Slang.
Refs #1385
Fixes #1602
Note: Work-in-progress
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batchcommand line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: