This repository was archived by the owner on Dec 2, 2024. It is now read-only.
Repository navigation
Conversation
Member
Author
|
See also the thread starting here: #79 (comment) |
This fixes Safari and Edge. These browsers do not send localhost URLs via a proxy; with a fake domain they do.
Member
Author
|
Pros of a single job for browser tests (f7879d5):
Cons:
|
Member
Author
|
Restarting the build just to test: https://travis-ci.org/Level/memdown/builds/281860132 |
Member
Author
|
@ralphtheninja it looks like the browser tests are actually stable now. |
Member
Author
|
Depends on defunctzombie/zuul#323. |
Member
|
@vweevers Fuckin' A! So we wait until |
Member
Author
|
Yea, but I'm not sure it's still actively maintained.. |
Member
Worst case scenario, we can use your fork for now. |
Member
Seems @feross can help us out if @defunctzombie doesn't have time |
| - name: ipad | ||
| version: latest | ||
| - name: android | ||
| version: latest |
ralphtheninja
approved these changes
Oct 1, 2017
Member
Author
|
Awesomesauce 😁 |
Member
|
@vweevers I vote for merging this now and worry about getting your fork into upstream later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge yet.
Changes:
Pros:
Cons:
Need to: