Skip to content
This repository was archived by the owner on Dec 2, 2024. It is now read-only.

New sauce - #81

Merged
vweevers merged 5 commits into
masterfrom
new-sauce
Oct 1, 2017
Merged

vweevers merged 5 commits into
masterfrom
new-sauce

Conversation

@vweevers

@vweevers vweevers commented Oct 1, 2017 •

Copy link
Copy Markdown
Member

Do not merge yet.

Changes:

  • New credentials
  • Use Sauce Connect instead of localtunnel
  • Use JWT addon
  • Enable debug output for zuul (on this flaky platform any info is welcome)

Pros:

  • Sauce Connect is probably more reliable
  • With Sauce Connect + JWT, PRs can also use Sauce Labs 💯

Cons:

Need to:

  • rebase and squash
  • make a PR to zuul (or temporarily drop Safari and Edge)
  • I want to try running all browsers in one travis job, see if this does work with Sauce Connect

@vweevers vweevers self-assigned this Oct 1, 2017
@vweevers
vweevers requested a review from ralphtheninja October 1, 2017 07:53
@vweevers

vweevers commented Oct 1, 2017

Copy link
Copy Markdown
Member Author

See also the thread starting here: #79 (comment)

@vweevers

vweevers commented Oct 1, 2017 •

Copy link
Copy Markdown
Member Author

Pros of a single job for browser tests (f7879d5):

  • Travis doesn't start Sauce Connect for non-browser tests, in fact, it only starts SC once
  • Reduces build time from 30 to 10 minutes 💯
  • Slightly cleaner build process / npm scripts

Cons:

  • Travis log is hard to read (interspersed results of multiple browsers), but we can view individual browsers in the Sauce Labs dashboard.

@vweevers

vweevers commented Oct 1, 2017

Copy link
Copy Markdown
Member Author

Restarting the build just to test: https://travis-ci.org/Level/memdown/builds/281860132

@vweevers

vweevers commented Oct 1, 2017

Copy link
Copy Markdown
Member Author

@ralphtheninja it looks like the browser tests are actually stable now.

@vweevers

vweevers commented Oct 1, 2017

Copy link
Copy Markdown
Member Author

Depends on defunctzombie/zuul#323.

@ralphtheninja

Copy link
Copy Markdown
Member

@vweevers Fuckin' A! So we wait until zuul has merged your fix?

@vweevers

vweevers commented Oct 1, 2017

Copy link
Copy Markdown
Member Author

Yea, but I'm not sure it's still actively maintained..

@ralphtheninja

Copy link
Copy Markdown
Member

Yea, but I'm not sure it's still actively maintained..

Worst case scenario, we can use your fork for now.

@ralphtheninja

Copy link
Copy Markdown
Member

@vweevers

$ npm owner ls zuul
defunctzombie <shtylman@gmail.com>
feross <feross@feross.org>
vvo <vincent.voyer@gmail.com>

Seems @feross can help us out if @defunctzombie doesn't have time

@Level Level deleted a comment from coveralls Oct 1, 2017
@Level Level deleted a comment from coveralls Oct 1, 2017
@Level Level deleted a comment from coveralls Oct 1, 2017
Comment thread .zuul.yml
- name: ipad
version: latest
- name: android
version: latest

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vweevers

vweevers commented Oct 1, 2017

Copy link
Copy Markdown
Member Author

Awesomesauce 😁

@ralphtheninja

Copy link
Copy Markdown
Member

@vweevers I vote for merging this now and worry about getting your fork into upstream later.

@vweevers
vweevers merged commit 2a17485 into master Oct 1, 2017
@vweevers
vweevers deleted the new-sauce branch October 1, 2017 17:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants