Skip to content

missing path in verifier message for payload directory #123

Description

@rvanheest

In MandatoryVerifier.checkPayloadDirectoryExists, when the bag/data directory does not exist, it returns "File [{}] should exist but it doesn't!". The path does not seemed to be filled in correctly.

Activity

  1. jscancella commented on Jul 12, 2018

    @jscancella
    Contributor

    @acdha line

    throw new MissingPayloadDirectoryException(messages.getString("file_should_exist_error"));
    should be
    throw new MissingPayloadDirectoryException(messages.getString("file_should_exist_error"), dataDir);

  2. rvanheest commented on Jul 12, 2018

    @rvanheest
    Author

    @jscancella shouldn't it also do something with MessageFormatter.format. I now see that in other places in that class as well...

  3. jscancella commented on Jul 12, 2018

    @jscancella
    Contributor

    @rvanheest yes, sorry that's what I get for replying too quickly. I had it in my head it was the logger, not an exception.

  4. added a commit that references this issue on Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions