Bag completeness for tag files #124

Activity

1. jscancella commented on Jul 20, 2018

   

   jscancella

   on Jul 20, 2018

   Contributor

   More actions

   @rvanheest and @acdha the PayloadVerifier actually does verify all files listed in all manifests. It should probably be renamed/refactored to make this more obvious

   It does this by first getting all the files listed in all manifests (see https://github.com/LibraryOfCongress/bagit-java/blob/master/src/main/java/gov/loc/repository/bagit/verify/PayloadVerifier.java#L115-L134) and then verifies them (see https://github.com/LibraryOfCongress/bagit-java/blob/master/src/main/java/gov/loc/repository/bagit/verify/PayloadVerifier.java#L102-L103)
2. rvanheest commented on Jul 20, 2018

   

   rvanheest

   on Jul 20, 2018

   Author

   More actions

   Thanks for the quick response (as always!). I now see what my confusion was: in PayloadVerifier I mainly looked at line 105-109 and glanced over 102-103. That one does the checking mentioned in my original post. The 105-109 part checks the opposite: "all files in the payload directory should be listed in all manifests".

   bagit-java/src/main/java/gov/loc/repository/bagit/verify/PayloadVerifier.java

   Lines 98 to 110 in 2b7002e

   	public void verifyPayload(final Bag bag, final boolean ignoreHiddenFiles)
   	throws IOException, MaliciousPathException, UnsupportedAlgorithmException,
   	InvalidBagitFileFormatException, FileNotInPayloadDirectoryException, InterruptedException {
   	final Set<Path> allFilesListedInManifests = getAllFilesListedInManifests(bag);
   	checkAllFilesListedInManifestExist(allFilesListedInManifests);
   	if (bag.getVersion().isOlder(new Version(1, 0))) {
   	checkAllFilesInPayloadDirAreListedInAtLeastOneAManifest(allFilesListedInManifests, PathUtils.getDataDir(bag), ignoreHiddenFiles);
   	} else {
   	CheckAllFilesInPayloadDirAreListedInAllManifests(bag.getPayLoadManifests(), PathUtils.getDataDir(bag), ignoreHiddenFiles);
   	}
   	}

   Thanks for the clarification. That helped a lot.
   Yes, refactoring this a bit probably won't hurt.
3. rvanheest

   added a commit that references this issue on Feb 20, 2019

   refs LibraryOfCongress#124 renamed to make it more clear that we veri…

   ...

   eff1c35