Repository navigation
Update self.log #132
Description
🐛 Bug
Some tutorials still return non-detached tensors in training_step - this is deprecated in 1.6 and may cause memory leaks if people follow those patterns.
e.g.
output = OrderedDict({"loss": g_loss, "progress_bar": tqdm_dict, "log": tqdm_dict})
The error pops up in the autogenerated docs here: https://pytorch-lightning.readthedocs.io/en/stable/notebooks/lightning_examples/basic-gan.html
I raised this in Lightning-Universe/lightning-bolts#793 too.
I see the examples in https://github.com/PyTorchLightning/pytorch-lightning/tree/master/pl_examples already defer to lightning bolts for more robust examples - wherever a good source of docs/best practices should be, I think this specific error be fixed? (these examples are also discussed in #71).
Thanks, loving the library btw! :)
Activity
Borda commentedon Jan 7, 2022
Hi @loodvn are you interested in sending out fix? :]
loodvn commentedon Jan 17, 2022
Unfortunately not, sorry - Lightning-Universe/lightning-bolts#793 (comment)
stale commentedon Apr 16, 2025
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.