Skip to content

MacOS support - #20

Merged
LinusU merged 5 commits into
LinusU:masterfrom
sallaben:macos
Apr 13, 2020
Merged

LinusU merged 5 commits into
LinusU:masterfrom
sallaben:macos

Conversation

@sallaben

Copy link
Copy Markdown
Contributor

Adds MacOS >=10.15 support to flutter_web_auth.

Please let me know if you have any questions or suggestions!

@sallaben

Copy link
Copy Markdown
Contributor Author

I would suggest browsing the difference by commit.

cfceb4d has the class itself
0e0c773 has /example/macos files
26180cb has GIF of macos behavior.

@sallaben

sallaben commented Apr 7, 2020

Copy link
Copy Markdown
Contributor Author

@LinusU would like to use this in my project and I'm sure others would too :)

@LinusU

LinusU commented Apr 7, 2020

Copy link
Copy Markdown
Owner

Sorry for the delay, will try to take a look this weekend 👀

@sallaben

sallaben commented Apr 12, 2020 •

Copy link
Copy Markdown
Contributor Author

Hey, any luck? (i promise this is my last bump tho)

Comment thread pubspec.yaml
plugin:
androidPackage: com.linusu.flutter_web_auth
pluginClass: FlutterWebAuthPlugin
platforms:

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks older versions of Flutter so I will release this as a breaking change

@LinusU

LinusU commented Apr 13, 2020

Copy link
Copy Markdown
Owner

(i promise this is my last bump tho)

Don't feel bad bumping! I have 321 unread notifications that I still have to get to right now, and many of them are just noise, so this puts it at the top 😅

I'm pushing some fixups directly to your branch, for future reference please don't bump the version in the PR, I want to do that in a separate commit. (in fact, I'm automating it with emoji-commit)

Also I would recommend to configure your editor to automatically insert final newline character to avoid this:

Screenshot 2020-04-13 at 10 26 01

and to remove trailing whitespace to avoid this:

Screenshot 2020-04-13 at 10 27 24

I also ran ImageOptim on the images to save some space, trimmed a few frames from the gif, added macOS info to the readme and some other minor cleanups.

@LinusU
LinusU merged commit 7289dd1 into LinusU:master Apr 13, 2020
@LinusU

LinusU commented Apr 13, 2020

Copy link
Copy Markdown
Owner

Thank you so much for this 🎉

@LinusU

LinusU commented Apr 13, 2020

Copy link
Copy Markdown
Owner

Released as 🚢 0.2.0 / 2020-04-13

@eldadfux

Copy link
Copy Markdown

Great work!! @LinusU @sallaben 👏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants