Repository navigation
Conversation
|
@allistar @dwrobel @smoe @jethornton @phillc54 @petterreinholdtsen @hansu @20after4 can you guys please test this? |
|
When @SebKuzminsky pushed commit ee2623b, that commit did cause issue on Buster (and possibly older) systems where there would be a non-transparent pixel in each character block that made the preview overlays look noisy. I tested and passed my findings to Seb and he pushed commit 710ce7e. I never saw the original issue (crash) Seb sought to fix on my Bullseye based VM. For what it's worth, I did take the time to apply the changes in this commit to my Buster based VM and it has no issues with noisy pixels this time. So from a Buster standpoint, this change seems fine to me. But I do wonder if this will cause issue for the original group of people (whoever they were)? I guess that comes down to how similar None and ''.encode() are? I don't have hardware that has crashes with this, so it's hard for me to test otherwise. |
|
It works for me on Bullseye X11 and Bookworm X11 It crashes with the following on Bookworm Wayland |
|
I think this patch is an improvement and should be accepted.
The difference should be between a null pointer (~ The GL manpage specifically has a note about using
So this sounds like a bug with your OpenGL implementation (or a lack thereof). What implementation are you using? If it's not a bug in the driver, then the error checking might trigger for a previous command (example, if Did you try to run it through apitrace or some other OpenGL debugger? |
The Bookworm Wayland install is just a basic up to date install with whatever dependencies that LinuxCNC requires. I still get the error on this machine if I log in to an XFCE session. I did make a mistake though, I missed this earlier message:
No. |
|
I just ran apitrace, and the call looks correct, so None is the correct parameter. |
|
@phillc54 can you upload a apitrace trace file on a non working system? |
|
I am not sure that I am doing this correctly. apitrace is v11.1+repack-1.1 installed with Synaptic. The line now reads: This is the result: |
|
Can you open and run the trace file in qapitrace(apitrace-gui package), and see if it reports other errors? |
|
Could you also provide the output of "glxinfo"? |
|
Sure. |
|
You're using the software renderer, so maybe it's an issue in the mesa software renderer? |
|
Would that be because all of the tests I did were on VM's? Although this machine should be identical to the one with X11. |
|
Yes. I don't know, if this is a bug in the mesa software render, because nobody nowadays uses these outdated functions, however it seems to be related to the following codepath in mesa: https://gitlab.freedesktop.org/mesa/mesa/-/blob/main/src/mesa/main/dlist.c#L1351 |
|
If it is any help I just ran up the X11 VM which runs fine and ran glxinfo, attached is the diff between the X11 and Wayland VM's. |
|
OK, I made a mistake. I hadn't upgraded my X11 VM for the previous test and since upgrading it also gives the same error. I am now getting this error on four up to date Bookworm VM's, two amd64 and two arm64. Unfortunately I don't have a bare metal Bookworm to test on. |
Looks like a generic mesa bug or underspecification in OpenGL about:
I've created an issue about mesa in https://gitlab.freedesktop.org/mesa/mesa/-/issues/8904
So I was wrong, due to it all being very vague in the OpenGL specification. The mesa issue will probably affect many users for the next couple of years (until a potential fix is rolled out completly). I now think a better solution would be to have a 0x0, 0x1/1x0 or 1x1 image with a non-zero valid buffer. It should avoid all previously mentioned issues (but you might want to read the spec again to make sure). |
|
The best solution is, to replace glBitmap in this place and instead just use normal translations to achieve the same effect. I will build a prototype for this in the coming week. |
|
I implemented a workaround: fced097 |
|
I have no idea. A later version of mesa has a fix included for glBitmap https://gitlab.freedesktop.org/mesa/mesa/-/commit/bac1c88ea3e1f0966505a3bfb016c6b2e8cbb629 but shall we wait for that? Merged three months ago, https://gitlab.freedesktop.org/mesa/mesa/-/tags suggests that 23.1.3 or later are fine. On https://tracker.debian.org/pkg/mesa it states that current testing should no longer be affected. I do not understand what the patch is doing. I suggest leaving it in with a comment to remove it when 23.1.3 or later has become a runtime requirement. |
|
The patch tries the other way in case the first way fails. It's a hack, but works. |
The code was the same in both 2.9 and master so it's my vote that we keep them consistent until 2.9 is released. |
|
stuttgart meeting says leave the workaround in until mesa is fixed upstream. |
|
Apparently fixed by bde2cdc |


No description provided.