Repository navigation
feat(roles/repo_monitoring_plugins)!: install the monitoring plugins from the Linuxfabrik repository - #500
Merged
Conversation
The deb822 file is read by apt 2.2.4 on Debian 11, which checks the signature and skips the disabled testing stanza (verified against the bookworm suite, bullseye is served once Linuxfabrik/packaging builds for it).
…from the Linuxfabrik repository repo_monitoring_plugins only removes the former repository files (and the apt keyring only they referenced), keeping the rpm key, which also signs the Linuxfabrik repository. The playbooks run repo_linuxfabrik for the package install. The run aborts while a former variable is set. Molecule: monitoring_plugins split into install and migrate.
markuslf
force-pushed
the
feat/monitoring-plugins-repo-linuxfabrik
branch
from
October 27, 2026 18:55
3697662 to
e8634f5
Compare
markuslf
marked this pull request as ready for review
October 27, 2026 18:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The merge gate is met: Linuxfabrik Monitoring Plugins 8.1.0, the first release built by Linuxfabrik/packaging (Linuxfabrik/packaging#56), is in the
releasechannel of repo.linuxfabrik.ch since 2026-10-27, on all targets. #489 and #491 are merged; this branch is rebased onto main, and thesetup_icinga2_masterconflict with #491 is resolved:repo_linuxfabrikruns together withacme_shor with the package install of the monitoring plugins.The RPM and DEB build of the monitoring plugins moves to Linuxfabrik/packaging, which publishes to the Linuxfabrik repository (
el/<ver>/<arch>/linuxfabrik/<channel>/and so on) instead of repo.linuxfabrik.ch/monitoring-plugins/. The former tree is frozen and is removed after a transition period.Changes
repo_monitoring_pluginsonly removes the former repository: everylinuxfabrik-monitoring-plugins*file in/etc/yum.repos.d,/etc/zypp/repos.dand/etc/apt/sources.list.d(including the backups and the files oftools/install-monitoring-plugins), and/etc/apt/keyrings/linuxfabrik.asc. The rpm key stays, since it also signs the Linuxfabrik repository. The role is deprecated.repo_monitoring_plugins__basic_auth_login,__mirror_urlor__testingis set, naming therepo_linuxfabrik__*replacement.repo_linuxfabrik__testing_repo_enabledadds the testing channel instead of replacing the release channel.monitoring_pluginsandicinga2_agentrunrepo_monitoring_plugins(cleanup), thenrepo_linuxfabrikformonitoring_plugins__install_method: 'package'(*_skip_repo_linuxfabrik).setup_basicalready deploysrepo_linuxfabrik(feat(roles/repo_linuxfabrik): add role #489);setup_icinga2_masterruns it after EPEL together with the package install of the monitoring plugins. This is the spot feat(roles/acme_sh): install acme.sh from the Linuxfabrik repository #491 uses for acme.sh. The conflict there comes down to OR-ing the two default conditions.repo_linuxfabriksupports Debian 11, which the monitoring plugins are built for until 2027-02-28. apt 2.2.4 reads the deb822 file, checks the signature and skips the disabled testing stanza (verified against the bookworm suite; bullseye is served once Linuxfabrik/packaging builds for it).--tags monitoring_plugins:remove.Tests
monitoring_pluginsis split intoinstall(fresh host) andmigrate(8.0.0 installed and locked from the former repository). verify checks that the latest release runs and came from the Linuxfabrik repository (from_repo/apt-cache madison), that nothing of the former repository is left, and that the lock moved to the new version. On EL it also checks that-selinuxwas upgraded along.monitoring_plugins_source/removeno longer expects the rpm key to be gone.repo_linuxfabrikruns ondebian11-vmtoo.linuxfabrik.ascwere removed, the Linuxfabrik repository was active, the lock was kept, and the second run reportedchanged=0. Withrepo_monitoring_plugins__testing=true, the run aborted with the hint.pre-commitandtests/unit/test_playbooks.pypass.ansible-lintreports nothing in the changed files.