Repository navigation
Conversation
wbruna
force-pushed
the
kcpp_sd_vlm_images
branch
2 times, most recently
from
November 16, 2026 22:03
877e9a6 to
eba0eec
Compare
Several were enabled by the new generic image reference support.
wbruna
force-pushed
the
kcpp_sd_vlm_images
branch
from
November 17, 2026 22:31
eba0eec to
b0d316e
Compare
Owner
|
Will review and merge this soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detects some model types (currently tokenizers, mmprojs and the p-h3 connector) by inspecting the file, and add support for passing images to the VLM ( leejet/stable-diffusion.cpp@5d78740 ).
The improved detection is needed for the image prompts, because a lot of new models can now load mmprojs.
Also includes p-h3 connector detection support.
Moved from, and on top of, #2576 . Moving here the discussion too:
<image:N>map to the extra images array; they are by default removed from the reference images passed to sd.cpp<image:+N>mean "image for both the VLM and the reference image list"A few arguably questionable choices 🙂 :
<image:0>, the index becomes zero-based, instead of the whole thing failing. Happy to drop it, if you think it's too magical.<image:N>withimageN, to keep the prompt consistent, and give a chance to an edit model to understand it. Again, no hard feelings if you prefer aborting the gen.