Cases set only the parameters their equation of state reads

.github/scripts/check_coverage_map_health.py

@@ -1,11 +1,10 @@
 """Fail loudly if the committed coverage map is stale or under-covers. Used by coverage-health.yml."""
 import datetime
-import subprocess
 import sys
 from pathlib import Path
 
 sys.path.insert(0, str(Path(__file__).resolve().parents[2] / "toolchain"))
-from mfc.test.coverage import COVERAGE_MAP_PATH, load_map, map_health  # noqa: E402
+from mfc.test.coverage import COVERAGE_MAP_PATH, _git, load_map, map_health  # noqa: E402
 from mfc.test.cases import list_cases  # noqa: E402  (returns the current test list)
 
 MAX_AGE_DAYS = 10
@@ -40,7 +39,7 @@ def verified_sha(cwd=None):
     caller must read that as undeterminable and fall back to the wall-clock age rule, not
     as a failure -- an absent ref is not evidence of a broken refresh.
     """
-    rev = subprocess.run(["git", "rev-parse", "--verify", "--quiet", f"{VERIFIED_REF}^{{commit}}"], capture_output=True, text=True, check=False, cwd=cwd)
+    rev = _git(["rev-parse", "--verify", "--quiet", f"{VERIFIED_REF}^{{commit}}"], cwd)
     return rev.stdout.strip() or None
 
 
@@ -53,10 +52,10 @@ def verified_after_last_change(git_sha, cwd=None):
     """
     if not git_sha:
         return None
-    last = subprocess.run(["git", "log", "-1", "--format=%H", "--", *COVERAGE_RELEVANT_PATHS], capture_output=True, text=True, check=False, cwd=cwd)
+    last = _git(["log", "-1", "--format=%H", "--", *COVERAGE_RELEVANT_PATHS], cwd)
     if last.returncode != 0 or not last.stdout.strip():
         return None  # shallow clone or no such commit -> fall back to the age rule
-    ancestor = subprocess.run(["git", "merge-base", "--is-ancestor", last.stdout.strip(), git_sha], capture_output=True, check=False, cwd=cwd)
+    ancestor = _git(["merge-base", "--is-ancestor", last.stdout.strip(), git_sha], cwd)
     return {0: True, 1: False}.get(ancestor.returncode)  # anything else -> None (unknown sha, shallow history)
 
 

examples/1D_advection_convergence/case.py

@@ -95,10 +95,8 @@
             "patch_icpp(1)%alpha(2)": "0.5 - 0.2 * sin(2.0 * pi * x / lx)",
             "fluid_pp(1)%gamma": 1.0 / (gamma - 1.0),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
             "fluid_pp(2)%gamma": 1.0 / (gamma - 1.0),
             "fluid_pp(2)%eos": "ideal_gas",
-            "fluid_pp(2)%pi_inf": 0.0,
             **scheme_params,
         }
     )

examples/1D_brio_wu/case.py

@@ -74,7 +74,6 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0e00 / (2.0e00 - 1.0e00),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
         }
     )
 )

examples/1D_brio_wu_hlld/case.py

@@ -75,7 +75,6 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0e00 / (2.0e00 - 1.0e00),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
         }
     )
 )

examples/1D_brio_wu_rmhd/case.py

@@ -76,7 +76,6 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0e00 / (2.0e00 - 1.0e00),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
         }
     )
 )

examples/1D_convergence/case.py

@@ -74,10 +74,8 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0e00 / (1.4 - 1.0e00),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
             "fluid_pp(2)%gamma": 1.0e00 / (1.4 - 1.0e00),
             "fluid_pp(2)%eos": "ideal_gas",
-            "fluid_pp(2)%pi_inf": 0.0,
         }
     )
 )

examples/1D_dai_woodward/case.py

@@ -83,7 +83,6 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0e00 / ((5.0 / 3.0) - 1.0e00),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
         },
     )
 )

examples/1D_dai_woodward_hlld/case.py

@@ -84,7 +84,6 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0e00 / ((5.0 / 3.0) - 1.0e00),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
         },
     )
 )

examples/1D_euler_convergence/case.py

@@ -100,7 +100,6 @@
             "patch_icpp(1)%alpha(1)": 1.0,
             "fluid_pp(1)%gamma": 1.0 / (gamma - 1.0),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
             **scheme_params,
         }
     )

examples/1D_hypo_2materials/case.py

@@ -83,7 +83,6 @@
             "fluid_pp(1)%G": 1.0e09,
             "fluid_pp(2)%gamma": 1.0e00 / (1.4e00 - 1.0e00),
             "fluid_pp(2)%eos": "ideal_gas",
-            "fluid_pp(2)%pi_inf": 0.0,
             "fluid_pp(2)%G": 0.0,
         }
     )

examples/1D_kapilashocktube/case.py

@@ -69,7 +69,6 @@
             "fluid_pp(1)%pi_inf": 4.4e00 * 6.0e08 / (4.4e00 - 1.0e00),
             "fluid_pp(2)%gamma": 1.0e00 / (1.4e00 - 1.0e00),
             "fluid_pp(2)%eos": "ideal_gas",
-            "fluid_pp(2)%pi_inf": 0.0e00,
         }
     )
 )

examples/1D_laxshocktube/case.py

@@ -68,7 +68,6 @@
             # air: an ideal gas, so it carries no stiffness and pi_inf is not read
             "fluid_pp(1)%eos": "ideal_gas",
             "fluid_pp(1)%gamma": 1.0e00 / (1.4 - 1.0e00),
-            "fluid_pp(1)%pi_inf": 0.0,
         }
     )
 )

examples/1D_mhd_smooth_alfven_wave/case.py

@@ -62,7 +62,6 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0e00 / (5.0 / 3.0 - 1.0e00),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
         }
     )
 )

examples/1D_shuosher_analytical/case.py

@@ -69,7 +69,6 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0e00 / (1.4 - 1.0e00),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
         }
     )
 )

examples/1D_shuosher_old/case.py

@@ -70,7 +70,6 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0e00 / (1.4 - 1.0e00),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
         }
     )
 )

examples/1D_shuosher_teno5/case.py

@@ -72,7 +72,6 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0e00 / (1.4 - 1.0e00),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
         }
     )
 )

examples/1D_shuosher_teno7/case.py

@@ -72,7 +72,6 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0e00 / (1.4 - 1.0e00),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
         }
     )
 )

examples/1D_shuosher_wenojs5/case.py

@@ -71,7 +71,6 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0e00 / (1.4 - 1.0e00),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
         }
     )
 )

examples/1D_shuosher_wenom5/case.py

@@ -71,7 +71,6 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0e00 / (1.4 - 1.0e00),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
         }
     )
 )

examples/1D_shuosher_wenoz5/case.py

@@ -71,7 +71,6 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0e00 / (1.4 - 1.0e00),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
         }
     )
 )

examples/1D_sod_convergence/case.py

@@ -99,7 +99,6 @@
             "patch_icpp(2)%alpha(1)": 1.0,
             "fluid_pp(1)%gamma": 1.0 / (gamma - 1.0),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
             **scheme_params,
         }
     )

examples/1D_sodshocktube/case.py

@@ -70,7 +70,6 @@
             # air: an ideal gas, so it carries no stiffness and pi_inf is not read
             "fluid_pp(1)%eos": "ideal_gas",
             "fluid_pp(1)%gamma": 1.0e00 / (1.4 - 1.0e00),
-            "fluid_pp(1)%pi_inf": 0.0,
         }
     )
 )

examples/1D_sodshocktube_muscl/case.py

@@ -65,7 +65,6 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0e00 / (1.4 - 1.0e00),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
         }
     )
 )

examples/1D_titarevtorro/case.py

@@ -68,7 +68,6 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0e00 / (1.4 - 1.0e00),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
         }
     )
 )

examples/1D_titarevtorro_analytical/case.py

@@ -67,7 +67,6 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0e00 / (1.4 - 1.0e00),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
         }
     )
 )

examples/1D_vacuum/case.py

@@ -69,7 +69,6 @@
             "fluid_pp(1)%pi_inf": 4.4e00 * 6.0e08 / (4.4e00 - 1.0e00),
             "fluid_pp(2)%gamma": 1.0e00 / (1.4e00 - 1.0e00),
             "fluid_pp(2)%eos": "ideal_gas",
-            "fluid_pp(2)%pi_inf": 0.0e00,
         }
     )
 )

examples/1D_vacuum_restart/case.py

@@ -69,7 +69,6 @@
             "fluid_pp(1)%pi_inf": 4.4e00 * 6.0e08 / (4.4e00 - 1.0e00),
             "fluid_pp(2)%gamma": 1.0e00 / (1.4e00 - 1.0e00),
             "fluid_pp(2)%eos": "ideal_gas",
-            "fluid_pp(2)%pi_inf": 0.0e00,
         }
     )
 )

examples/2D_GreshoVortex/case.py

@@ -81,7 +81,6 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0e00 / (gam - 1.0e00),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
         }
     )
 )

examples/2D_IGR_2fluid/case.py

@@ -69,11 +69,9 @@
     # Fluid Parameters (Gas)
     "fluid_pp(1)%gamma": 1.0e00 / (1.4e00 - 1.0e00),
     "fluid_pp(1)%eos": "ideal_gas",
-    "fluid_pp(1)%pi_inf": 0.0e00,
     "fluid_pp(1)%Re(1)": 1e5,
     "fluid_pp(2)%gamma": 1.0e00 / (1.4e00 - 1.0e00),
     "fluid_pp(2)%eos": "ideal_gas",
-    "fluid_pp(2)%pi_inf": 0.0e00,
     "fluid_pp(2)%Re(1)": 1e5,
     # Ambient pressure
     "patch_icpp(1)%geometry": 3,

examples/2D_IGR_triple_point/case.py

@@ -96,10 +96,8 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0 / (1.5 - 1.0),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0,
             "fluid_pp(2)%gamma": 1.0 / (1.4 - 1.0),
             "fluid_pp(2)%eos": "ideal_gas",
-            "fluid_pp(2)%pi_inf": 0.0,
         }
     )
 )

examples/2D_TaylorGreenVortex/case.py

@@ -71,7 +71,6 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0e00 / (gam_a - 1.0e00),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
             # Shear viscosity of STD air
             "fluid_pp(1)%Re(1)": 1 / Mu,
         }

examples/2D_acoustic_broadband/case.py

@@ -78,7 +78,6 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0e00 / (1.4e00 - 1.0e00),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0,
         }
     )
 )

examples/2D_acoustic_pulse/case.py

@@ -98,7 +98,6 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0e00 / (gam - 1.0e00),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
         }
     )
 )

examples/2D_acoustic_pulse_analytical/case.py

@@ -97,7 +97,6 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0e00 / (gam - 1.0e00),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
         }
     )
 )

examples/2D_advection/case.py

@@ -81,7 +81,6 @@
             "fluid_pp(1)%pi_inf": 2.35e00 * 1.0e09 / (2.35e00 - 1.0e00),
             "fluid_pp(2)%gamma": 1.0e00 / (1.4e00 - 1.0e00),
             "fluid_pp(2)%eos": "ideal_gas",
-            "fluid_pp(2)%pi_inf": 0.0e00,
         }
     )
 )

examples/2D_advection_convergence/case.py

@@ -111,7 +111,6 @@
             "patch_icpp(1)%alpha(1)": 1.0,
             "fluid_pp(1)%gamma": 1.0 / (gamma - 1.0),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
             **scheme_params,
         }
     )

examples/2D_advection_muscl/case.py

@@ -79,7 +79,6 @@
             "fluid_pp(1)%pi_inf": 2.35e00 * 1.0e09 / (2.35e00 - 1.0e00),
             "fluid_pp(2)%gamma": 1.0e00 / (1.4e00 - 1.0e00),
             "fluid_pp(2)%eos": "ideal_gas",
-            "fluid_pp(2)%pi_inf": 0.0e00,
         }
     )
 )

examples/2D_axisym_shockbubble/case.py

@@ -112,10 +112,8 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0e00 / (1.4e00 - 1.0e00),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
             "fluid_pp(2)%gamma": 1.0e00 / (1.6666e00 - 1.0e00),
             "fluid_pp(2)%eos": "ideal_gas",
-            "fluid_pp(2)%pi_inf": 0.0e00,
         }
     )
 )

examples/2D_backward_facing_step/case.py

@@ -82,7 +82,6 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0 / (gam_a - 1.0),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
             "fluid_pp(1)%Re(1)": 1 / mu,
         },
         indent=4,

examples/2D_bingham_poiseuille_nn/case.py

@@ -119,7 +119,6 @@
             # Fluids Physical Parameters: single Bingham (HB with n = 1, tau0 > 0) fluid
             "fluid_pp(1)%gamma": 1.0 / (1.4 - 1.0),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
             "fluid_pp(1)%Re(1)": 1.0 / K,
             "fluid_pp(1)%non_newtonian": "T",
             "fluid_pp(1)%K": K,

examples/2D_forward_facing_step/case.py

@@ -79,7 +79,6 @@
             # Fluids Physical Parameters
             "fluid_pp(1)%gamma": 1.0 / (gam_a - 1.0),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
             "viscous": "T",
             "fluid_pp(1)%Re(1)": 1 / mu,
         },

examples/2D_hardcoded_ic/case.py

@@ -74,7 +74,6 @@
             "fluid_pp(1)%pi_inf": 2.35e00 * 1.0e09 / (2.35e00 - 1.0e00),
             "fluid_pp(2)%gamma": 1.0e00 / (1.4e00 - 1.0e00),
             "fluid_pp(2)%eos": "ideal_gas",
-            "fluid_pp(2)%pi_inf": 0.0e00,
         }
     )
 )

examples/2D_herschel_bulkley_poiseuille_nn/case.py

@@ -126,7 +126,6 @@
             # Fluids Physical Parameters: single Herschel-Bulkley (n != 1, tau0 > 0) fluid
             "fluid_pp(1)%gamma": 1.0 / (1.4 - 1.0),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
             "fluid_pp(1)%Re(1)": 1.0 / K,
             "fluid_pp(1)%non_newtonian": "T",
             "fluid_pp(1)%K": K,

examples/2D_hypo_shear_contact/case.py

@@ -83,11 +83,9 @@
             "fd_order": 4,
             "fluid_pp(1)%gamma": 1.0 / (gamma - 1.0),
             "fluid_pp(1)%eos": "ideal_gas",
-            "fluid_pp(1)%pi_inf": 0.0,
             "fluid_pp(1)%G": G,
             "fluid_pp(2)%gamma": 1.0 / (gamma - 1.0),
             "fluid_pp(2)%eos": "ideal_gas",
-            "fluid_pp(2)%pi_inf": 0.0,
             "fluid_pp(2)%G": G,
             # Left/background state.
             "patch_icpp(1)%geometry": 3,