Repository navigation
Fix stale build, parameter, and CI claims in docs and comments - #1986
Draft
sbryngelson wants to merge 1 commit into
Draft
sbryngelson wants to merge 1 commit into
sbryngelson wants to merge 1 commit into
Conversation
- Generated-file header and NAMELIST_VARS comment said to regenerate via a
cmake reconfigure; generation is a build-time custom command
(cmake/ParamsCodegen.cmake).
- copilot-instructions told reviewers to flag PRs that do not hand-edit the
namelist/m_global_parameters, which are now generated from definitions.py;
point at NAMELIST_VARS instead. Same fix in architecture.md.in.
- contributing.md: drop the stale "15 files" count; '#:if MFC_SIMULATION'
is a Fypp NameError in pre/post_process and false in simulation (fypp -D
without a value binds None), so use '#:if defined('MFC_SIMULATION')';
cleanliness.yml only reports warning increases and never fails, so say so
and drop the "Warnings increased" CI-failure row; the PR template has no
GPU checklist, so point to gpuParallelization instead.
- getting-started.md: 'params --family' is rejected by argparse; the flag
is --families.
- gpuParallelization.md: '$:$GPU_PARALLEL_LOOP' typo.
- Parameter counts (~3,300 / ~3,400 / over 3,000): './mfc.sh params' reports
4211. Docs now say "over 4,000"; code docstrings and CLI help drop the
number.
Verified: fypp from build/venv on a scratch file reproduces the NameError and
the None-is-false behavior of '#:if MFC_SIMULATION', while the defined() form
selects the right branch per target; './mfc.sh params --families' works and
'--family' errors; params_tests and lint_docs pass.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmake reconfigure; generation is a build-time custom command
(cmake/ParamsCodegen.cmake).
namelist/m_global_parameters, which are now generated from definitions.py;
point at NAMELIST_VARS instead. Same fix in architecture.md.in.
is a Fypp NameError in pre/post_process and false in simulation (fypp -D
without a value binds None), so use '#:if defined('MFC_SIMULATION')';
cleanliness.yml only reports warning increases and never fails, so say so
and drop the "Warnings increased" CI-failure row; the PR template has no
GPU checklist, so point to gpuParallelization instead.
is --families.
4211. Docs now say "over 4,000"; code docstrings and CLI help drop the
number.
Verified: fypp from build/venv on a scratch file reproduces the NameError and
the None-is-false behavior of '#:if MFC_SIMULATION', while the defined() form
selects the right branch per target; './mfc.sh params --families' works and
'--family' errors; params_tests and lint_docs pass.