Skip to content

Read 2D chemistry probe species after locating the probe - #1989

Draft
sbryngelson wants to merge 1 commit into
MFlowCode:masterfrom
sbryngelson:fix/2d-chem-probe-indices
Draft

sbryngelson wants to merge 1 commit into
MFlowCode:masterfrom
sbryngelson:fix/2d-chem-probe-indices

Conversation

@sbryngelson

Copy link
Copy Markdown
Member

In the 2D branch of s_write_probe_files the species partial densities
were read from q_cons_vf(j-2, k-2, l) before j, k and l were computed
for the current probe and outside the ownership check, so they used the
previous probe's cell or, for the first probe, uninitialized indices.
A gfortran debug run of a 2D chemistry case with probes aborted on an
out-of-bounds index.

Move the read inside the ownership branch after the indices are set,
as in the 1D and 3D branches.


Acknowledgement

  • I confirm this PR meets the above expectations and reflects my own understanding and real-world context.

In the 2D branch of s_write_probe_files the species partial densities
were read from q_cons_vf(j-2, k-2, l) before j, k and l were computed
for the current probe and outside the ownership check, so they used the
previous probe's cell or, for the first probe, uninitialized indices.
A gfortran debug run of a 2D chemistry case with probes aborted on an
out-of-bounds index.

Move the read inside the ownership branch after the indices are set,
as in the 1D and 3D branches.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant