Repository navigation
Remove dead locals and unused argument in s_get_capillary - #1997
Closed
sbryngelson wants to merge 1 commit into
Closed
sbryngelson wants to merge 1 commit into
sbryngelson wants to merge 1 commit into
Conversation
isx/isy/isz were set but never read (and the isy guard tested m instead of n). s_reconstruct_cell_boundary_values_capillary never used norm_dir, which the caller filled from the loop index i, undefined at that point. Pure dead-code removal; surface tension tests pass unchanged.
Lines of Code
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isx/isy/isz were set but never read (and the isy guard tested m instead
of n). s_reconstruct_cell_boundary_values_capillary never used norm_dir,
which the caller filled from the loop index i, undefined at that point.
Pure dead-code removal; surface tension tests pass unchanged.
Acknowledgement
Consolidated into draft PR #2022. This change is retained as a separate commit, and this original description is reproduced in full there. Original discussion remains available here.