Repository navigation
Fix GPU_HOST_DATA and GPU_DECLARE argument handling - #1999
Draft
sbryngelson wants to merge 1 commit into
Draft
sbryngelson wants to merge 1 commit into
sbryngelson wants to merge 1 commit into
Conversation
GPU_HOST_DATA with both use_device_addr and use_device_ptr tried to assign into a Python string, which fails at Fypp time. Join the two bracketed lists into one instead. GPU_DECLARE passed extraAccArgs=None to ACC_DECLARE, silently dropping the caller's value. Pass it through. Verified with Fypp: a scratch file using both macros now expands to '!$acc host_data use_device(a, b, c)' / '!$omp target data use_device_addr(a, b) use_device_ptr(c)' and keeps extraAccArgs on '!$acc declare'. Fypp output for every pre_process, simulation, post_process and common source is byte-identical before and after for MFC_COMPILER = NVHPC, LLVMFlang and Cray, since no existing call site uses either path.
Lines of Code
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GPU_HOST_DATA with both use_device_addr and use_device_ptr tried to
assign into a Python string, which fails at Fypp time. Join the two
bracketed lists into one instead.
GPU_DECLARE passed extraAccArgs=None to ACC_DECLARE, silently dropping
the caller's value. Pass it through.
Verified with Fypp: a scratch file using both macros now expands to
'!$acc host_data use_device(a, b, c)' / '!$omp target data
use_device_addr(a, b) use_device_ptr(c)' and keeps extraAccArgs on
'!$acc declare'. Fypp output for every pre_process, simulation,
post_process and common source is byte-identical before and after for
MFC_COMPILER = NVHPC, LLVMFlang and Cray, since no existing call site
uses either path.
Acknowledgement