Repository navigation
Restrict sim_data to 3D two-fluid 5/6-equation cases - #2008
Closed
sbryngelson wants to merge 1 commit into
Closed
sbryngelson wants to merge 1 commit into
sbryngelson wants to merge 1 commit into
Conversation
post_process's sim_data writers are hard-wired to one configuration: s_write_energy_data_file multiplies by dz (unallocated in 1D/2D), reads adv(2) and alpha_rho(2) and the volume fractions at eqn_idx%E + 1 and eqn_idx%E + 2, and s_write_intf_data_file thresholds q_prim_vf(eqn_idx%E + 2). Any other case read unallocated memory or the wrong variables. Reject sim_data unless p > 0, num_fluids = 2 and model_eqns is 2 or 3, and cover the check in test_case_validator.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
post_process's sim_data writers are hard-wired to one configuration:
s_write_energy_data_file multiplies by dz (unallocated in 1D/2D), reads
adv(2) and alpha_rho(2) and the volume fractions at eqn_idx%E + 1 and
eqn_idx%E + 2, and s_write_intf_data_file thresholds
q_prim_vf(eqn_idx%E + 2). Any other case read unallocated memory or the
wrong variables.
Reject sim_data unless p > 0, num_fluids = 2 and model_eqns is 2 or 3,
and cover the check in test_case_validator.py.
Acknowledgement
Consolidated into draft PR #2023. This change is retained as a separate commit, and this original description is reproduced in full there. Original discussion remains available here.