Skip to content

Missing script referenced in COMPASS Ocean #220

Closed

Description

@xylar

A script, mesh_comparison.py is referenced in COMPASS's new globa_ocean test cases:
https://github.com/MPAS-Dev/MPAS-Model/blob/ocean/develop/testing_and_setup/compass/ocean/global_ocean/config_files/config_mesh_metrics.xml#L7

This file is pointing to MPAS-Tools/mesh_tools/mesh_comparison.py, but there doesn't seem to be any such file:
https://github.com/MPAS-Dev/MPAS-Tools/tree/master/mesh_tools

A little sleuthing suggests it's here:
https://github.com/sbrus89/MPAS-Tools/blob/jigsaw_mesh_creation/mesh_tools/mesh_comparison.py
but hasn't been merged and I didn't see a PR.

@sbrus89, is the solution to add this tool? Or to remove reference to it from COMPASS for now?

Activity

  1. sbrus89 commented on Apr 30, 2019

    @sbrus89

    @xylar, Thanks for bringing this up. I don't think the script is ready to be merged at the moment. (It has paths that are hard-coded etc.) My feeling is that we should probably remove the reference for now. It should never have made it in without having the tool merged. Sorry about that.

  2. xylar commented on Apr 30, 2019

    @xylar
    CollaboratorAuthor

    Okay, no problem. I'll remove it as part of a bigger commit I'm working on.

  3. added a commit that references this issue on May 10, 2019
    e2cc405
  4. added a commit that references this issue on Jun 28, 2019
  5. added 2 commits that reference this issue on Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions