You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Vertical loop error for tend_w in mpas_atm_time_integration.F #5
Matus Martini and I discovered a bug at line 2488 of mpas_atm_time_integration.F. This line loops from k=1,nVertLevels to calculate tend_w. However, ru_edge_w(k) is only given values for k=2,nVertLevels.
We believe the appropriate fix is just to change line 2488 to loop from k=2,nVertLevels since the w-tendency is always zero at the bottom anyway, and it is given that value higher up in the subroutine.
-Bill
William I. Gustafson Jr., Ph.D.
Scientist
ATMOSPHERIC SCIENCES AND GLOBAL CHANGE DIVISION
We noticed NAN values for tend_w at k=1 distributed randomly in blocks around the earth. This is just a cosmetic correction since the tend_w at k=1 do not seem to be used later in the integration.
Matus
Matus Martini
Postdoctoral Research Associate
Atmospheric Sciences and Global Change Division
Pacific Northwest National Laboratory
Tel: 509-372-4082
Thanks for catching this; as it's often useful to be able to run the code with floating-point trapping enabled, this is a fix we'll be glad to make. Since the problem is cosmetic, rather than creating another bug-fix release, I'll include the changes in our development repository, and fix fix will appear in the next feature release (2.0) that should be out in a month or two.
Activity
matusmartini commentedon Sep 17, 2013
Hi Michael,
We noticed NAN values for tend_w at k=1 distributed randomly in blocks around the earth. This is just a cosmetic correction since the tend_w at k=1 do not seem to be used later in the integration.
Matus
Matus Martini
Postdoctoral Research Associate
Atmospheric Sciences and Global Change Division
Pacific Northwest National Laboratory
Tel: 509-372-4082
mgduda commentedon Oct 2, 2013
Hi, Matus and Bill.
Thanks for catching this; as it's often useful to be able to run the code with floating-point trapping enabled, this is a fix we'll be glad to make. Since the problem is cosmetic, rather than creating another bug-fix release, I'll include the changes in our development repository, and fix fix will appear in the next feature release (2.0) that should be out in a month or two.
Thanks, again!
Michael
Merge pull request MPAS-Dev#5 from mgduda/atmosphere/openacc_flag_cle…
Remove assimilation namelist from default nml (#5)
Add max_level to new subroutine names
Merge pull request MPAS-Dev#5 from xylar/add_recipe
Merge pull request #5 from akturner/seaice/ridging_island_testcase
Reduce file size via 2-stream model initialization and DA cycling (MP…
Merge pull request MPAS-Dev#5 from akturner/seaice/ridging_island_tes…
Reduce file size via 2-stream model initialization and DA cycling (MP…
Merge pull request MPAS-Dev#5 from jeremy-lilly/tidal_potential_fix
Merge pull request MPAS-Dev#5 from LarissaReames-NOAA/atmosphere/nssl…
Updates to Thompson-Eidhammer microphysics and MPAS to support future…
26 remaining items
Fix memory leak in mpas_stream_manager.F
Fix memory leak in stream_inquiry.c
Fix memory leak in mpas_io.F
Fix memory leak in mpas_pool_routines.F
Fix memory leak in mpas_framework.F and mpas_domain_routines.F
Fix memory leak in mpas_domain_routines.F
Fix memory leak in xml_stream_parser
Fix memory leak in mpas_io.F
Fix memory leak in mpas_domain_routines.F
Fix memory leak in mpas_pool_routines.F
Fix memory leak in mpas_block_creator.F
Fix memory leak in block_dimension_routines.inc
Fix memory leak in mpas_io.F
Provide default initialization for members of the met_data derived type
Merge branch 'init_atmosphere/met_data_default_init' into develop (PR M…