Skip to content

Relative links to analysis not compatible with COMPASS work directory #517

Closed

Description

@xylar

Several test cases refer to relative paths to analysis that is not linked properly when the test case is set up with the --work_dir flag. These test cases are:

 53: -o ocean -c drying_slope -r hybrid -t 1km
 54: -o ocean -c drying_slope -r hybrid -t 250m
 57: -o ocean -c drying_slope -r sigma -t 1km
 58: -o ocean -c drying_slope -r sigma -t 250m
 59: -o ocean -c drying_slope -r zstar -t 1km
 60: -o ocean -c drying_slope -r zstar -t 250m
 131: -o ocean -c surface_waves -r direct -t 1km
 132: -o ocean -c surface_waves -r thickness_source -t 1km

As an example from https://github.com/MPAS-Dev/MPAS-Model/blob/ocean/develop/testing_and_setup/compass/ocean/drying_slope/hybrid/1km/config_analysis.xml#L3-L5:

  <add_link source="../../../analysis/comparison.py" dest="comparison.py"/>
  <add_link source="../../../analysis/movie.py" dest="movie.py"/>
  <add_link source="../../../analysis/data" dest="data"/>

Since analysis is not a test case itself (it has no config_driver.xml), it does not get copied to the work directory. These links therefore need to be provided in this way instead:

  <add_link source_path="script_configuration_dir" source="analysis/comparison.py" dest="comparison.py"/>
  <add_link source_path="script_configuration_dir" source="analysis/movie.py" dest="movie.py"/>
  <add_link source_path="script_configuration_dir" source="analysis/data" dest="data"/>

Activity

  1. xylar commented on Apr 9, 2020

    @xylar
    CollaboratorAuthor

    I am working on a PR to fix issues like this and will just include these changes on the ocean/develop side but wanted to point them out to see how these fixes can make their way into ocean/coastal, particularly in new test cases.

  2. pwolfram commented on Apr 9, 2020

    @pwolfram
    Contributor

    Thank you @xylar, much appreciated.

  3. added a commit that references this issue on Apr 10, 2020
    60470a0
  4. xylar commented on May 7, 2020

    @xylar
    CollaboratorAuthor

    Addressed by #514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions