Repository navigation
Pass hydrostatic surface pressure to the YSU and MYNN PBL schemes - #1522
Merged
mgduda merged 1 commit intoOct 13, 2026
Merged
Conversation
The PBL driver passes the hydrostatic pressures pres_hyd_p and pres2_hyd_p to YSU and MYNN, but the full (non-hydrostatic) surface pressure psfc_p. MYNN computes the lowest-layer thickness delp(kts) from both, so when the non-hydrostatic deviation of a column approaches rho*g*dz of the lowest layer, delp(kts) goes to zero and the division dp(k)/dp(k-1) in moisture_check yields NaN. Passing psfc_hyd_p, which comes from the same hydrostatic integration, makes delp(kts) positive by construction and matches WRF, where module_pbl_driver sets PSFC = p8w(kms) from the hydrostatic p_hyd_w.
Collaborator
|
Thank you for pointing out this issue. I agree with the proposed change. Given that these schemes use delta-p derived from hydrostatic pressure to represent layer mass, using hydrostatic surface pressure seems like a consistent and safe approach here. |
jihyeonjang
approved these changes
Oct 9, 2026
mgduda
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PBL driver passes the hydrostatic pressures pres_hyd_p and pres2_hyd_p to YSU and MYNN, but the full (non-hydrostatic) surface pressure psfc_p. MYNN computes the lowest-layer thickness delp(kts) from both, so when the non-hydrostatic deviation of a column approaches rhogdz of the lowest layer, delp(kts) goes to zero and the
division dp(k)/dp(k-1) in moisture_check yields NaN.
Passing psfc_hyd_p, which comes from the same hydrostatic integration, makes delp(kts) positive by construction and matches WRF, where module_pbl_driver sets PSFC = p8w(kms) from the hydrostatic p_hyd_w.
The problem was discovered during 1 km real data simulations with MPAS over steep terrain.