Skip to content

undocumented breaking changes with 2.32.0 - express v5 #3835

Closed

Description

@skuethe

What problem do you want to solve with this change?

It seems you switched to express version 5 with the latest update. Unfortunately there seems to be no hint to this in the release notes.
express v5 introduced breaking changes which are documented here:
https://expressjs.com/en/guide/migrating-5.html

This is especially critical for the this.expressapp helper you provide:
https://docs.magicmirror.builders/development/node-helper.html#this-expressapp

What do you think is the correct solution?

It would be very helpful to add this hint as a breaking change (targeting module developers) in the release notes of v2.32.0

Participation

  • I am willing to submit a pull request for this change.

Additional comments

No response

Activity

  1. dathbe commented on Jul 5, 2025

    @dathbe
    Contributor

    The breaking changes do not seem to be limited to upgrading the express version. Here are additional apps that seem to refuse to work upon upgrade to 2.32.0:

    updatenotification (will not load)
    MMM-CalendarExt2 (will not load)
    MMM-LogExt (relies on express, though throws errors even when express v4 is explicitly loaded as a dependency)
    MMM-OpenWeatherMapForecast
    MMM-MyStandings

    See below for update

  2. sdetweil commented on Jul 5, 2025

    @sdetweil
    Collaborator

    updatenotification loads for me on 2.32
    calendarext2 is deprecated, use Ext3
    MMM-LogExt works on 2.32

  3. sdetweil commented on Jul 5, 2025

    @sdetweil
    Collaborator

    my MMM-Config uses get/redirect (2 different routes) and 2 diffent post without problem

  4. dathbe commented on Jul 5, 2025

    @dathbe
    Contributor

    I'm going to delete my comment. At least partially, my list is a symptom of not installing node packages as we discussed last night.

  5. sdetweil commented on Jul 5, 2025

    @sdetweil
    Collaborator

    yes, when things get messed up, they get messed up..

    delete node_modules folder and do another
    npm run install-mm
    or npm install (if you do MM development)

  6. dathbe commented on Jul 5, 2025

    @dathbe
    Contributor

    calendarext2 is deprecated, use Ext3

    "Only week and month views. I found that people are rarely interested in other views on CX2. So I drop out different views."
    https://github.com/MMRIZE/MMM-CalendarExt3

    calendarext2 is not deprecated, it just has a more updated version for some functions.

  7. sdetweil commented on Jul 5, 2025

    @sdetweil
    Collaborator

    Ext2 is no longer being developed or supported. maybe the deprecated word hasn't been used.. but thats the effective result
    ext3 Agenda/.... do the other views, better (imho)

  8. dathbe commented on Jul 5, 2025

    @dathbe
    Contributor

    @KristjanESPERANTO updated it a couple months ago. It was working great under v2.31.0. I think that's the last module that's not working for me after the upgrade to v2.32.0. Possibly still due to something I've borked. Working on it now.

  9. khassel commented on Jul 5, 2025

    @khassel
    Collaborator

    It seems you switched to #3774 with the latest update. Unfortunately there seems to be no hint to this in the release notes.

    we never mention detailed dependency updates except electron. As long as our tests are green we upgrade. So best would be to write a test for this ...

    I think I can update the release notes here and in the forum, will place a hint for this there later.

  10. khassel commented on Jul 5, 2025

    @khassel
    Collaborator

    I think I can update the release notes here and in the forum, will place a hint for this there later.

    added a hint

  11. skuethe commented on Jul 5, 2025

    @skuethe
    Author

    Thank you <3 and keep up the good work :)

  12. KristjanESPERANTO commented on Jul 6, 2025

    @KristjanESPERANTO
    Collaborator

    calendarext2 is deprecated, use Ext3

    To set the records straight: Ext2 is maintained, not by by the original author but by another team. Ext3, however, is quasi unmaintained (see the forum).

  13. sdetweil commented on Jul 6, 2025

    @sdetweil
    Collaborator

    Ok, wasn't aware it had shifted to a new team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions