Repository navigation
fix: node discovery warning message spam #514
Description
Activity
- added a commit that references this issue
on Mar 19, 2023 Moved comment, ignore this.
Moved comment, ignore this.
Moved comment, ignore this.
Moved comment, ignore this.
Moved comment, ignore this.
Moved comment, ignore this.
I have been commenting on the wrong issue. Let me fix that...
- added a commit that references this issue
on Mar 21, 2023 This was an opportunistic fix to prevent a bunch of logger warning messages during testing. Strictly speaking, failing to connect to all of the seed nodes is concerning. Not having any seeds nodes to connect to is not.
Example of logger messages from testing, specifically
Failed to connect to any seed nodes when syncing node graph.WARN:agentUnlock test.NodeManager:Failed to connect to any seed nodes when syncing node graph WARN:agentUnlock test:Failed to verify identity claim between v07bvphcua9efa29q9dl5ro7taqkkik59oei5roeab45evfn40i60 and ["test-provider","trusted-node"] WARN:agentUnlock test.NodeManager:Failed to connect to any seed nodes when syncing node graph WARN:agentUnlock test.NodeManager:Failed to connect to any seed nodes when syncing node graph WARN:agentUnlock test:Failed to verify identity claim between v5j6hiij5sspo0g6l2ue2adtgstvl82cmtcjgdu1t3odf1d9kinig and ["test-provider","trusted-node"] WARN:agentUnlock test:Failed to verify identity claim between v5j6hiij5sspo0g6l2ue2adtgstvl82cmtcjgdu1t3odf1d9kinig and ["test-provider","trusted-node"] WARN:agentUnlock test.NodeManager:Failed to connect to any seed nodes when syncing node graph WARN:NodeManager:Failed to connect to any seed nodes when syncing node graph WARN:agentUnlock test.NodeManager:Failed to connect to any seed nodes when syncing node graph WARN:agentUnlock test.NodeManager:Failed to connect to any seed nodes when syncing node graph
Specification
When providing no seed nodes to connect to we would end up with logger warning messages
Failed to connect to any seed nodes when syncing node graph. Since a lot of tests start aPolykeyAgentwith no seed nodes provided, this ended up with a lot of useless warning messages during tests.This can be fixed by checking if there are any provided seed nodes and skip discovery if none are provided.
Additional context
Tasks
NodeManager.