Skip to content

Minor review and refactor of vaults domain for 'polykey' #718

Description

@tegefaulkes

Specification

As part of refactoring the git domain in #298 we need to do a small review of the vaults domain for any fixes and improvements. This is a general refactor and review. We're looking for any places that can be tidied up if needed. Some tests need to be re-enabled as well.

Additional context

Tasks

  1. General review of the vaults domain.
  2. Have a closer look at the vaults committing secrets and git garbage collection code.
  3. Determine and apply any optimisations that can be made.
  4. Review vaults tests and clean them up if needed.
  5. Re-enable any tests that have been disabled.
  6. Possibly split up some test files so the vaults domain runs quicker in CI. vault ops is currently very slow.

Activity

  1. self-assigned this
    on May 13, 2024
  2. tegefaulkes commented on May 20, 2024

    @tegefaulkes
    ContributorAuthor

    Yeah, there's definitely some weird interaction with linear going on here.

  3. CMCDragonkai commented on May 20, 2024

    @CMCDragonkai
    Member

    You got to be more descriptive with your issue title in the future...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions